1755220 - Cookies are not updated in Storage Inspector for Private Browsing windows

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P3)

Description

[Thayne]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:96.0) Gecko/20100101 Firefox/96.0

Steps to reproduce:

Open a new "Private window".
Open a website.
Open dev tools and inspect cookies for the domain.
Press the "+" button to add an item, or right click and select "Add Item"

Actual results:

Nothing.

Expected results:

A new Cookie should have been added, like it does in a normal non-private window.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Private Browsing' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Peter Magyari (Desktop QA)]

Reproducible on Firefox 97 and Firefox Nightly 99.0a1

Although I'm not entirely sure if this should work in private window-mode or not I'm setting a component in order to get the development team involved in reviewing it.

Thank you for reporting!

Comment 3

[Thayne]

If it shouldn't work in private window mode, then the UI for it should probably be disabled right?

Comment 4

[Julian Descottes [:jdescottes]]

Adding a cookie in Private Browsing windows actually "works", but the UI is not updated.
If you close and reopen DevTools you will see a new cookie was created.
Same thing if you keep devtools open and navigate away and then back.

And it doesn't seem to be specific to using the Add button in the UI. If you dynamically add a cookie from JS (eg document.cookie = "sc1=foobar;";) it will also not update the storage table.

Comment 5

[Julian Descottes [:jdescottes]]

Nicolas to track down why we are missing updates for Private Browsing Windows

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

We only listen for cookie-changed (devtools/server/actors/storage.js#1139), but in private mode, the topic is private-cookie-changed, so we miss cookies update in private windows.
Not sure if we have other things to consider, but https://phabricator.services.mozilla.com/D141970 fixes issue from Comment 0

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1755220 - [devtools] Observe private-cookie-changed in storage actor. r=jdescottes.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7563df479749
[devtools] Observe private-cookie-changed in storage actor. r=jdescottes.

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7563df479749

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1755220 - [devtools] Fix add test second param in browser_storage_cookies_add.js.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1f3a4b91db7
[devtools] Fix add test second param in browser_storage_cookies_add.js.

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a1f3a4b91db7