1755415 - Ship most compiler-rts alongside clang toolchains on all platforms

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1755415 - Encode the target in the compiler-rt artifact/directory.

This simplifies the setup for cross clang repacks.

Also use ninja install to get all the relevant things in the artifact.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1755415 - Create tasks for the linux x86 and x64 compiler-rt.

Use lld to build them (as well as aarch64 linux compiler-rt).

While here, remove redundant CMAKE_SHARED_LINKER_FLAGS in the Android case.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1755415 - Stop using cctools to build mac compiler-rt.

This allows to build the compiler-rt earlier.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1755415 - Use compiler-rt artifacts for clang PGO.

Instead of building compiler-rt alongside clang, we reuse the clang
repack logic to put compiler-rts in place when building clang stage2
(which requires the profiling runtime).

The repack logic is unified to handle all platforms as well, and now
that compiler-rt is not built in clang, we also need to copy everything
that is not lib/* from the compiler-rt artifacts, so we now also ensure
that they're not diverging between those compiler-rt artifacts (except
for darwin libs, which need to be unified into universal libraries).

And as a bonus, we can also cross-build the mac clang toolchains with
the stage1 clang and the clang runtime for the target platform.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1755415 - Ship most compiler-rts alongside clang toolchains on all platforms.

This improves out-of-the-box support for cross-compiles on tier-1 build
platforms, including for asan. This also reduces the number of different
*-cross toolchains we need for CI builds.

The linux clang is now also a repack, like the others, and the insertion
of the wasm compiler-rt is moved to the repack, which also allows to
remove that part of the build-clang.py script.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a5c1fe00f26
Encode the target in the compiler-rt artifact/directory. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/709af6e17057
Create tasks for the linux x86 and x64 compiler-rt. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/a84913234c63
Stop using cctools to build mac compiler-rt. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/69d9d8005a83
Use compiler-rt artifacts for clang PGO. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/e836c26855d4
Ship most compiler-rts alongside clang toolchains on all platforms. r=firefox-build-system-reviewers,mhentges

Comment 7

[Marian-Vasile Laza]

Backed out 5 changesets (Bug 1755415) for causing build bustages.
Backout link
Push with failures
Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de4b01930cff
Encode the target in the compiler-rt artifact/directory. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/c42c67a91b3e
Create tasks for the linux x86 and x64 compiler-rt. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/3996b904323e
Stop using cctools to build mac compiler-rt. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/2e45b678b24b
Use compiler-rt artifacts for clang PGO. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/52f3ec5b41fd
Ship most compiler-rts alongside clang toolchains on all platforms. r=firefox-build-system-reviewers,mhentges

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/de4b01930cff
https://hg.mozilla.org/mozilla-central/rev/c42c67a91b3e
https://hg.mozilla.org/mozilla-central/rev/3996b904323e
https://hg.mozilla.org/mozilla-central/rev/2e45b678b24b
https://hg.mozilla.org/mozilla-central/rev/52f3ec5b41fd