Closed Bug 1755447 Opened 10 months ago Closed 8 months ago

[wpt-sync] Sync PR 32844 - Correct legacy pagination layer DCHECK in pre-paint.

Categories

(Core :: Layout: Columns, task, P4)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32844 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32844
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Correct legacy pagination layer DCHECK in pre-paint.

Floats inside inlines get special treatment in the legacy engine, in
that their Container() (LayoutObject) is the nearest containing block,
rather than the parent. This needs to be reflected everywhere in the
code. We already have special-code for it in e.g.
LayoutObject::PaintingLayer() and PaintPropertyTreeBuilder::
UpdatePaintingLayer(). The DCHECK also needs to join the party.

LayoutObject::FlowThreadContainingBlock() has special behavior for
column spanners inside nested multicol (it will just return nullptr if
it finds a spanner on its way), which is what caused trouble here.

Bug: 1297118
Change-Id: Ie18adf148f0fa31ec1a10eaaf2efc2c074b07e9d
Reviewed-on: https://chromium-review.googlesource.com/3461658
WPT-Export-Revision: bff50362ae09aee443542b4edf39738c1d970b58

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a70b79eae50
[wpt PR 32844] - Correct legacy pagination layer DCHECK in pre-paint., a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.