Closed Bug 1755450 Opened 8 months ago Closed 8 months ago

Bug 1754519 broke !MOZ_GECKO_PROFILER builds

Categories

(Core :: Gecko Profiler, defect, P3)

All
OpenBSD
defect

Tracking

()

VERIFIED FIXED
99 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox97 --- unaffected
firefox98 --- unaffected
firefox99 --- fixed

People

(Reporter: gaston, Assigned: florian)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Builds on OpenBSD (and probably solaris) now fail:

52:53.57 /build/buildslave-amd64/mozilla-central-amd64/build/ipc/chromium/src/base/message_pump_libevent.cc:113:5: error: use of undeclared identifier 'profiler_thread_wake'
52:53.62 /build/buildslave-amd64/mozilla-central-amd64/build/ipc/chromium/src/base/message_pump_libevent.cc:249:5: error: use of undeclared identifier 'profiler_thread_wake'
52:53.78 /build/buildslave-amd64/mozilla-central-amd64/build/ipc/chromium/src/base/message_pump_libevent.cc:371:9: error: use of undeclared identifier 'profiler_thread_sleep'; did you mean 'profiler_thread_is_sleeping'?
Severity: -- → S3
Priority: -- → P3
Duplicate of this bug: 1755254

Set release status flags based on info from the regressing bug 1754519

Has Regression Range: --- → yes
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #9264270 - Attachment description: Bug 1755450 - implement empty stub profiler_thread_sleep and profiler_thread_wake functions for tier3 platforms not building mOZ_GECKO_PROFILER, r=gerald. → Bug 1755450 - implement empty stub profiler_thread_sleep and profiler_thread_wake functions for tier3 platforms not building MOZ_GECKO_PROFILER, r=gerald.

testing the above fix, it fails later on:

50:46.38 In file included from Unified_cpp_tools_profiler0.cpp:20:
50:46.38 In file included from /home/landry/src/m-c/tools/profiler/core/ProfilerThreadRegistration.cpp:12:
50:46.38 In file included from /home/landry/src/m-c/tools/profiler/core/platform.h:32:
50:46.39 /home/landry/src/m-c/tools/profiler/core/PlatformMacros.h:127:4: error: "Unsupported platform"
50:46.39 #  error "Unsupported platform"
50:46.39    ^
50:50.37 3 warnings and 1 error generated.

did something else change wrt that ?

I see the same for Solaris.

(In reply to Landry Breuil (:gaston) from comment #4)

testing the above fix, it fails later on:

50:46.38 In file included from Unified_cpp_tools_profiler0.cpp:20:
50:46.38 In file included from /home/landry/src/m-c/tools/profiler/core/ProfilerThreadRegistration.cpp:12:
50:46.38 In file included from /home/landry/src/m-c/tools/profiler/core/platform.h:32:
50:46.39 /home/landry/src/m-c/tools/profiler/core/PlatformMacros.h:127:4: error: "Unsupported platform"
50:46.39 #  error "Unsupported platform"
50:46.39    ^
50:50.37 3 warnings and 1 error generated.

did something else change wrt that ?

Thanks for checking!

I should ifdef out the platform.h include that was added to access the profiler_mark_thread_awake and profiler_mark_thread_asleep functions.

I'm now rebuilding locally to check if the patch from bug 1755055 requires more ifdefs.

See Also: → 1755889

(In reply to Florian Quèze [:florian] from comment #6)

I should ifdef out the platform.h include that was added to access the profiler_mark_thread_awake and profiler_mark_thread_asleep functions.

I updated the patch to do this. Would you like to test the new version, or should I just go ahead and land it?

I'm now rebuilding locally to check if the patch from bug 1755055 requires more ifdefs.

Seems to build fine.

Flags: needinfo?(landry)

yes, m-c built fine for me with the last iteration of https://phabricator.services.mozilla.com/D138957, thanks !

Flags: needinfo?(landry)
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72752c43d243
implement empty stub profiler_thread_sleep and profiler_thread_wake functions for tier3 platforms not building MOZ_GECKO_PROFILER, r=gerald.

Backed out for causing build bustages on ProfilerThreadRegistration.cpp

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/tools/profiler/core/ProfilerThreadRegistration.cpp:14:7: error: extra tokens at end of #else directive [-Werror,-Wextra-tokens]
Flags: needinfo?(florian)

whoopsie, indeed #else MOZ_GECKO_PROFILER should just be #else ? didnt fail here but i dont thing our clang 13 on openbsd defaults to -Wextra-tokens,-Werror

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/952151a54ac8
implement empty stub profiler_thread_sleep and profiler_thread_wake functions for tier3 platforms not building MOZ_GECKO_PROFILER, r=gerald.
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch

(In reply to Cristian Tuns from comment #10)

Backed out for causing build bustages on ProfilerThreadRegistration.cpp

Sorry, that was a typo in the second version of the patch.

Flags: needinfo?(florian)

thanks florian for the quickfix, m-c tip is green for me now !

http://buildbot.rhaalovely.net/nine/#/builders/3/builds/1267

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.