1755458 - Crash in [@ mozilla::ipc::MessageChannel::Send | mozilla::ipc::IProtocol::ChannelSend | mozilla::dom::PWebGLChild::SendDispatchCommands]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Calixte Denizet (:calixte)]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/9fbdaeb6-6b82-423e-b2ab-4ea920220213

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(mWorkerThread && mWorkerThread->IsOnCurrentThread()) (not on worker thread!)

Top 10 frames of crashing thread:

0 libxul.so mozilla::ipc::MessageChannel::Send ipc/glue/MessageChannel.cpp:717
1 libxul.so mozilla::ipc::IProtocol::ChannelSend ipc/glue/ProtocolUtils.cpp:476
2 libxul.so mozilla::dom::PWebGLChild::SendDispatchCommands ipc/ipdl/PWebGLChild.cpp:168
3 libxul.so mozilla::dom::WebGLChild::FlushPendingCmds dom/canvas/WebGLChild.cpp:70
4 libxul.so mozilla::dom::WebGLChild::AllocPendingCmdBytes dom/canvas/WebGLChild.cpp:57
5 libxul.so void mozilla::ClientWebGLContext::Run<void  const dom/canvas/ClientWebGLContext.cpp:352
6 libxul.so mozilla::ClientWebGLContext::RawTexImage const dom/canvas/ClientWebGLContext.cpp:4228
7 libxul.so mozilla::gfx::DrawTargetWebgl::SharedContext::DrawRectAccel dom/canvas/DrawTargetWebgl.cpp:1422
8 libxul.so mozilla::gfx::DrawTargetWebgl::SharedContext::DrawPathAccel dom/canvas/DrawTargetWebgl.cpp:1770
9 libxul.so mozilla::gfx::DrawTargetWebgl::DrawPath dom/canvas/DrawTargetWebgl.cpp:1791

There are 11 crashes (from 4 installations) in nightly 99 starting with buildid 20220212212559. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1754130.

[1] https://hg.mozilla.org/mozilla-central/rev?node=f30dd1bddb47

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

This is because we use a single shared context, which is only valid on thread it is created on. We probably want a threadlocal shared context.

https://searchfox.org/mozilla-central/rev/d4d7611ee4dd0003b492b865bc5988a4e6afc985/dom/canvas/DrawTargetWebgl.h#229

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

This crash needs both OffscreenCanvas and accelerated canvas to be turned on.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1755458 - Use threadlocal shared WebGL context for accelerated canvas.

Because ClientWebGLContext is single threaded, we need a different
SharedContext for each thread that an accelerated Canvas2D is created
for.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20e06cb8a8fd
Use threadlocal shared WebGL context for accelerated canvas. r=lsalzman

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/20e06cb8a8fd