Enable more profiler xpcshell tests on Android
Categories
(Core :: Gecko Profiler, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox99 | --- | fixed |
People
(Reporter: canova, Assigned: canova)
References
Details
Attachments
(2 files)
Currently all of the xpcshell tests are skipped on Android. I'm changing this to skip the xpcshell test per test case instead of this global switch in Bug 1754781, also adding a basic test for profiling with "java" feature. But ideally, we should enable as much test as possible on Android, so we can catch the problems beforehand and bugs like Bug 1754781 won't be overlooked again.
I will try to enable all of them and send it to try. Also, I intend to figure out why we've disabled them in the first place.
Assignee | ||
Comment 1•2 years ago
|
||
I enabled them and pushed to try here: https://treeherder.mozilla.org/jobs?repo=try&revision=13e848e3cb07b1bd4ed75032979bb71d14c0e0cb
I had to change two tests slightly to update the regexps that are used inside the assertion statements. But otherwise, it looks like they are all passing. I think it should be fine to enable them all with that regexp change.
Assignee | ||
Comment 2•2 years ago
|
||
On an Android device, the stacks looks different during testing. It doesn't
include object directory before the test file since the tests are packaged
with the binary on Android.
Depends on D138769
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Depends on D138862
Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1e90638728ac Fix the Android regexp issues inside the xpcshell tests r=gerald https://hg.mozilla.org/integration/autoland/rev/d84757a03d57 Enable the profiler xpcshell tests for Android r=gerald
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1e90638728ac
https://hg.mozilla.org/mozilla-central/rev/d84757a03d57
Description
•