1755545 - [wpt-sync] Sync PR 32846 - App history: preserve id and entry object for same-document reloads

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32846 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32846
Details from upstream follow.

Domenic Denicola <[e-mail]> wrote:

App history: preserve id and entry object for same-document reloads

Although we skip most of RunURLAndHistoryUpdateSteps(), since we don't want to actually create a new history entry, we still perform some of the steps in UpdateForSameDocumentNavigation().

Notably, we run AppHistory::UpdateForNavigation(), which will fire a currentchange event and resolve any relevant promises. (However, per the guard newly-added in this CL, it won't replace the AppHistoryEntry object, or do any dispose event processing.)

Fixed: 1243749
Change-Id: I6c6195de649ba92c717222a4c059e1243e427b9c

Reviewed-on: https://chromium-review.googlesource.com/3425162
WPT-Export-Revision: c40a2f4367ff9dd16e7445bf676b5c64f65a005f

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e05c348848d59f31406a229e1cc0354208838a8

Comment 2

[Daniel Holbert [:dholbert]]

Note, this Try run ^ happened to be during a period where Try was busted, so it ended up with no tasks (unless someone manages to kick it and get those started).

We might need to get the wptsync-bot to retry that Try push, if it doesn't do so automatically.

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/app-history/app-history-entry/key-id-location-reload-transitionWhile.html
AppHistoryEntry's key and id after location.reload() intercepted by transitionWhile(): FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ea2e586d77a
[wpt PR 32846] - App history: preserve id and entry object for same-document reloads, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dfdfbdde9ca0
[wpt PR 32846] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d45d1f6a9dbd
[wpt PR 32846] - App history: preserve id and entry object for same-document reloads, a=testonly
https://hg.mozilla.org/integration/autoland/rev/88cfa937527c
[wpt PR 32846] - Update wpt metadata, a=testonly

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d45d1f6a9dbd
https://hg.mozilla.org/mozilla-central/rev/88cfa937527c