Closed Bug 1755688 Opened 2 years ago Closed 2 years ago

Remove macOS/Windows/Linux ifdefs from customizeMode.inc.css

Categories

(Firefox :: Toolbars and Customization, task, P3)

Desktop
All
task

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: Gijs, Assigned: bigiri)

References

Details

(Whiteboard: [fidefe-quality-foundation])

Attachments

(1 file)

https://searchfox.org/mozilla-central/source/browser/themes/shared/customizableui/customizeMode.inc.css has a handful of per-platform ifdefs. Now that bug 1754547 landed, it should be straightforward to replace them with media queries and stop pre-processing it.

It looks like we then include it on a per-platform basis in browser.css. Instead, we could have it be a standalone stylesheet and load it dynamically when entering customize mode for the first time (and await the inserted stylesheet loading, so we don't hit a flash of unstyled content), from CustomizeMode.jsm. At least at a glance, I don't think any of the rules in that sheet apply to anything outside of customize mode.

Assignee: nobody → bigiri
Status: NEW → ASSIGNED

Replaced OS specific preprocessor conditionals in customizeMode.inc.css with media queries.

Attachment #9264663 - Attachment description: WIP: Bug 1755688 - Removed preprocessor conditionals from customizeMode.inc.css → Bug 1755688 - Removed preprocessor conditionals from customizeMode.inc.css
Attachment #9264663 - Attachment description: Bug 1755688 - Removed preprocessor conditionals from customizeMode.inc.css → Bug 1755688 - Removed preprocessor conditionals from customizeMode.inc.css r=dao!
Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1cc0a484ab9f
Removed preprocessor conditionals from customizeMode.inc.css r=desktop-theme-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: