Closed Bug 1755714 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 32861 - Don't break before nested floated multicol at fragmentainer start.

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32861 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32861
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Don't break before nested floated multicol at fragmentainer start.

CL:3344659 made sure that we didn't freeze / crash, but it still
incorrectly pushed the float to the next fragmentainer. I knew that this
wasn't good, and since then I've realized that it wasn't even good
enough. :-P While analyzing crbug.com/1289532 (which this CL doesn't
fix), I came up with a test (nested-after-float-clearance.html) where we
end up wanting to push a float in front of us past multiple
fragmentainers, until we're past float clearance. And this failed
DCHECK(!BreakToken()) in NGColumnLayoutAlgorithm. It's fine to have an
incoming break token, as long it's a break-before break token.

Upgrade nested-floated-multicol-with-monolithic-child-crash.html to a
reftest, now that we're able to lay it out correctly.

Bug: 1280624
Change-Id: Iaa24e027a12c08abca44df5b700b566a640fe7a0
Reviewed-on: https://chromium-review.googlesource.com/3461383
WPT-Export-Revision: 1e0a3c36cb526bcc643b226f40184dd0661ffb51

Component: web-platform-tests → Layout: Columns
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb0e7427c223
[wpt PR 32861] - Don't break before nested floated multicol at fragmentainer start., a=testonly
https://hg.mozilla.org/integration/autoland/rev/edc63c8f4980
[wpt PR 32861] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/bb0e7427c223
https://hg.mozilla.org/mozilla-central/rev/edc63c8f4980

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.