1755768 - Assertion failure: mPresContext->GetVisibleArea().height != nscoord((1 << 30) - 1) (height should not be NS_UNCONSTRAINEDSIZE after reflow), at /layout/base/PresShell.cpp:2130

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev ae6487188557 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build ae6487188557 --debug --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Assertion failure: mPresContext->GetVisibleArea().height != nscoord((1 << 30) - 1) (height should not be NS_UNCONSTRAINEDSIZE after reflow), at /layout/base/PresShell.cpp:2130

    ==3384298==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7ff370dfea3c bp 0x7ffdf2baa040 sp 0x7ffdf2ba9fa0 T3384298)
    ==3384298==The signal is caused by a WRITE memory access.
    ==3384298==Hint: address points to the zero page.
        #0 0x7ff370dfea3c in mozilla::PresShell::ResizeReflowIgnoreOverride(int, int, mozilla::ResizeReflowOptions) /layout/base/PresShell.cpp:2128:3
        #1 0x7ff370e9488c in nsDocumentViewer::GetContentSizeInternal(int*, int*, int, int) /layout/base/nsDocumentViewer.cpp:2637:18
        #2 0x7ff370e94bf9 in nsDocumentViewer::GetContentSize(int*, int*) /layout/base/nsDocumentViewer.cpp:2668:10
        #3 0x7ff36da59623 in nsGlobalWindowOuter::SizeToContentOuter(mozilla::dom::CallerType, mozilla::ErrorResult&) /dom/base/nsGlobalWindowOuter.cpp:5580:16
        #4 0x7ff36ebbb5a0 in mozilla::dom::Window_Binding::sizeToContent(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/WindowBinding.cpp:5696:24
        #5 0x7ff36f17d954 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::MaybeCrossOriginObjectThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /dom/bindings/BindingUtils.cpp:3306:13
        #6 0x7ff372cd81cf in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) /js/src/vm/Interpreter.cpp:425:13
        #7 0x7ff372cd78cd in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:512:12
        #8 0x7ff372cd93ae in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /js/src/vm/Interpreter.cpp:572:10
        #9 0x7ff372ccec66 in CallFromStack /js/src/vm/Interpreter.cpp:576:10
        #10 0x7ff372ccec66 in Interpret(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:3309:16
        #11 0x7ff372cc5b63 in js::RunScript(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:394:13
        #12 0x7ff372cd77c8 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:544:13
        #13 0x7ff372cd93ae in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /js/src/vm/Interpreter.cpp:572:10
        #14 0x7ff372cd95b1 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:589:8
        #15 0x7ff372e093b1 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #16 0x7ff36ee9b1d7 in mozilla::dom::EventListener::HandleEvent(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/EventListenerBinding.cpp:62:8
        #17 0x7ff36f6824d6 in void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/EventListenerBinding.h:65:12
        #18 0x7ff36f68225a in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) /dom/events/EventListenerManager.cpp:1308:43
        #19 0x7ff36f682f59 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) /dom/events/EventListenerManager.cpp:1505:17
        #20 0x7ff36f677f64 in HandleEvent /dom/events/EventListenerManager.h:395:5
        #21 0x7ff36f677f64 in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:348:17
        #22 0x7ff36f677487 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:550:16
        #23 0x7ff36f679ce8 in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /dom/events/EventDispatcher.cpp:1085:11
        #24 0x7ff36f67c5a6 in mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*) /dom/events/EventDispatcher.cpp
        #25 0x7ff36dbc1754 in mozilla::dom::Document::DispatchPageTransition(mozilla::dom::EventTarget*, nsTSubstring<char16_t> const&, bool, bool, bool) /dom/base/Document.cpp:11593:3
        #26 0x7ff36dbc28ab in mozilla::dom::Document::OnPageHide(bool, mozilla::dom::EventTarget*, bool) /dom/base/Document.cpp:11749:7
        #27 0x7ff370e8fe3a in nsDocumentViewer::PageHide(bool) /layout/base/nsDocumentViewer.cpp:1389:14
        #28 0x7ff3724ab5f4 in nsDocShell::FirePageHideNotificationInternal(bool, bool) /docshell/base/nsDocShell.cpp:1233:20
        #29 0x7ff3724a47e0 in FirePageHideNotification /docshell/base/nsDocShell.cpp:1217:3
        #30 0x7ff3724a47e0 in nsDocShell::Destroy() /docshell/base/nsDocShell.cpp:4536:9
        #31 0x7ff37281bec0 in nsWebBrowser::SetDocShell(nsDocShell*) /toolkit/components/browser/nsWebBrowser.cpp:1123:18
        #32 0x7ff37281b445 in nsWebBrowser::InternalDestroy() /toolkit/components/browser/nsWebBrowser.cpp:176:3
        #33 0x7ff37281f12c in Destroy /toolkit/components/browser/nsWebBrowser.cpp:856:3
        #34 0x7ff37281f12c in non-virtual thunk to nsWebBrowser::Destroy() /toolkit/components/browser/nsWebBrowser.cpp
        #35 0x7ff370564e99 in mozilla::dom::BrowserChild::DestroyWindow() /dom/ipc/BrowserChild.cpp:880:31
        #36 0x7ff3705757db in mozilla::dom::BrowserChild::RecvDestroy() /dom/ipc/BrowserChild.cpp:2601:3
        #37 0x7ff36cfb1b0c in mozilla::dom::PBrowserChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PBrowserChild.cpp:6637:56
        #38 0x7ff36c99d73b in mozilla::dom::PContentChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PContentChild.cpp:8275:32
        #39 0x7ff36c80f6f1 in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /ipc/glue/MessageChannel.cpp:1661:25
        #40 0x7ff36c80cb32 in mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) /ipc/glue/MessageChannel.cpp:1586:9
        #41 0x7ff36c80d67d in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) /ipc/glue/MessageChannel.cpp:1454:3
        #42 0x7ff36c80e15d in mozilla::ipc::MessageChannel::MessageTask::Run() /ipc/glue/MessageChannel.cpp:1482:14
        #43 0x7ff36bd72e6e in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:467:16
        #44 0x7ff36bd4c096 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:770:26
        #45 0x7ff36bd4ad58 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:606:15
        #46 0x7ff36bd4afd3 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:390:36
        #47 0x7ff36bd76389 in operator() /xpcom/threads/TaskController.cpp:127:37
        #48 0x7ff36bd76389 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_1>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
        #49 0x7ff36bd60fe3 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1171:16
        #50 0x7ff36bd684fa in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:467:10
        #51 0x7ff36c814a44 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:107:5
        #52 0x7ff36c731bc7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #53 0x7ff36c731ad2 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #54 0x7ff36c731ad2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #55 0x7ff370ae9d98 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:137:27
        #56 0x7ff372b5b923 in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:878:20
        #57 0x7ff36c81598a in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:235:9
        #58 0x7ff36c731bc7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #59 0x7ff36c731ad2 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #60 0x7ff36c731ad2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #61 0x7ff372b5af5c in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:715:34
        #62 0x56483b0d1d37 in content_process_main /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #63 0x56483b0d1d37 in main /browser/app/nsBrowserApp.cpp:327:18
        #64 0x7ff380c790b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
        #65 0x56483b0ad4bc in _start (/home/jkratzer/builds/mc-debug/firefox-bin+0x154bc)
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /layout/base/PresShell.cpp:2128:3 in mozilla::PresShell::ResizeReflowIgnoreOverride(int, int, mozilla::ResizeReflowOptions)
    ==3384298==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220216214005-d0676cb0864b.
Unable to bisect testcase (Testcase reproduces on start build!):

Start: 791ad465a0c8344f38d54f0a226860fc26cfe540 (20210218041606)
End: ae64871885570edcdd3057d5ae758197b1dd5db4 (20220216094238)
BuildFlags: BuildFlags(asan=False, tsan=False, debug=True, fuzzing=True, coverage=False, valgrind=False, no_opt=False, fuzzilli=False)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:hiro, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Bugmon [:jkratzer for issues]]

Bugmon was unable reproduce this issue.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 5

[Jason Kratzer [:jkratzer]]

A change to the Taskcluster build definitions over the weekend caused Bugmon to fail when reproducing issues. This issue has been corrected. Re-enabling bugmon.

Comment 6

[Bugmon [:jkratzer for issues]]

Testcase crashes using the initial build (mozilla-central 20220716092056-c682cdddfbf1) but not with tip (mozilla-central 20230714094120-196cda3a1052.)

The bug appears to have been fixed in the following build range:

Start: c3ebb7d6ba529f418cf902555a70b5473bb99116 (20230711213659)
End: 71c6a10fe733e70437d71c03dcb30ad14f11e89e (20230711161753)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c3ebb7d6ba529f418cf902555a70b5473bb99116&tochange=71c6a10fe733e70437d71c03dcb30ad14f11e89e

jkratzer, can you confirm that the above bisection range is responsible for fixing this issue?
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 7

[Jason Kratzer [:jkratzer]]

Fixed via bug 1832733.