1755803 - [wpt-sync] Sync PR 32864 - Fix crash with content-visibility forced detach

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32864 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32864
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Fix crash with content-visibility forced detach

The problem was that
HTMLSlotElement::DetachDisplayLockedAssignedNodesLayoutTreeIfNeeded()
was called as part of a slot assignment recalc done from
AdjustDirectionalityIfNeededAfterChildrenChanged() from
ChildrenChanged() in ContainerNode::RemoveChildren(). The detach scope
object also covered ChildrenChanged, while the DisplayLock forced detach
did not have a dom removal scope.

Moved the detach scope around the actual removal and not surround the
ChildrenChanged() hook. If detaches happens in those hooks, the root
LayoutObject may even be different from the ContainerNode parent of the
removal. Those should have their own scopes if necessary.

Also, use in_detach_scope_ instead of in_dom_removal_ to figure out if
we should store the parent_for_detached_subtree_.

We don't add a scope around DetachDisplayLockedAssignedNodes... because
we do not want or need any layout tree adjustments inside the locked
subtree done by MarkForLayoutTreeChangesAfterDetach().

Bug: 1284278
Change-Id: Ibf4d4e21ddd9ad25e6bb0b013ca375b3b5b71ee5
Reviewed-on: https://chromium-review.googlesource.com/3468539
WPT-Export-Revision: 628bec770de56ada24e1d2004e3576f2043f7bc8

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=None

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f016570e0c8256d501d419007015258687dc0078

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8abff4f99055
[wpt PR 32864] - Fix crash with content-visibility forced detach, a=testonly

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8abff4f99055