1755820 - Extend memory reporter for TrackBuffersManager

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

It would be nice to have the TrackBuffersManager (and other parts of MediaSource) explicitly report further memory usage. This will help us better identify and track down memory issues that occur in media playback (like bug 1697476).

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Looks like bug 1190592 already did some work here, but we've got some gaps it would be nice to cover.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1755820 - Improve memory reporter in TrackBuffersManager.

This expands our memory reporting in TrackBuffersManager to cover additional
memory usage. Specifically it now reports several buffers where input data is
stored by the manager. These buffers will not typically take up that much space,
but it doesn't hurt to have them reported against media. Additionally, we've
just fixed a case where one of the buffers reported in this patch was growing
without bound, so it's nice to have some cover on that (bug 1697476 ). Reporting
these metrics will allow for testing of that bug too.

There is still more that could be reported from the TrackBuffersManager, but
that's a big yak to shave, so this patch intentionally does not attempt to do
so.

I've verified this works via about:memory and dmd.py (this also confirms there
are no double counts in my testing).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2e7f15a781e
Improve memory reporter in TrackBuffersManager. r=media-playback-reviewers,alwu

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c2e7f15a781e