1755824 - [WinOS] Focus outline in HCM should be text color rather than accent color

Status: RESOLVED DUPLICATE of bug 1860159

(Toolkit :: Themes, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Actual behavior of the focus indication for Save button on the Edit bookmark panel in WinOS HCM with green text color (theme #2)

STR

1. Enable HCM by turning in on under Settings > Ease of Access > Vision > High Contrast > Use high contrast
2. Choose a theme and confirm the Text color selection within the chosen theme (i.e. green for the High Contrast #2 theme)
3. In Firefox, Tab through the active UI controls and observe focus indication, i.e.:
   • Open the "Edit bookmark" panel from the address bar
   • Tab to the "Show editor when saving" checkbox, "Cancel"/"Remove bookmark" and "Save" buttons

Expected
Focus indicator should be using the Text color of the user selected HCM theme for all active UI

Actual
Focus indicator is using blue color that is not included in the color palette of the HCM across the UI.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1755023

Comment 2

[James Graham [:jgraham]]

Dão - This seems to be an a11y regression in nightly. Are we planning to address it in the 99 cycle?

Comment 3

[Dão Gottwald [:dao]]

I'll look into this.

Comment 4

[James Graham [:jgraham]]

Eithan: Do you consider this a blocker for 99?

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to James Graham [:jgraham] from comment #4)

Eithan: Do you consider this a blocker for 99?

Morgan is more knowledgeable on the HCM front, I'm going to have her answer this.

Comment 6

[Morgan Reschenberg [:morgan]]

I don't have my windows laptop on me today so can't confirm, but I believe this is a regression -- in which case it should be a blocker for 99.

:ayeddi can you confirm this is a regression?

Comment 7

[Anna Yeddi [:ayeddi]]

(In reply to Morgan Reschenberg [:morgan] from comment #6)

I don't have my windows laptop on me today so can't confirm, but I believe this is a regression -- in which case it should be a blocker for 99.

:ayeddi can you confirm this is a regression?

This is not a regression, but a bug.

Per Mozregression, it appears that the Text color for the --focus-outline was not used on primary buttons while on Windows OS HCM. This behavior first was introduced with the update of new style for "Edit bookmark" panel in April 2020 (the screenshot is attached below).

There were two options for primary buttons: either white or primary button blue outline, but not the Text color. The regressed bug 1755023 only changed the color from static white to static button blue.

Comment 8

[Anna Yeddi [:ayeddi]]

Attachment: Primary button Save with a focus outline that is not green (not Text HCM color)

Comment 9

[Anna Yeddi [:ayeddi]]

Attachment: Primary button Save with a focus outline that is not green (not Text HCM color)

Comment 10

[Donal Meehan [:dmeehan]]

Do we still plan on addressing this in the 99 cycle?
Is this a blocker?

Comment 11

[Dão Gottwald [:dao]]

(In reply to Donal Meehan [:dmeehan] from comment #10)

Do we still plan on addressing this in the 99 cycle?

Potentially yes, if we can come up with a simple enough patch.

Is this a blocker?

I don't think so.

Comment 12

[Dão Gottwald [:dao]]

Anna, do you know if this is still an issue? Has anything changed from when you reported this?

Comment 13

[Anna Yeddi [:ayeddi]]

Attachment: Win11-HCM-Bookmarks-Focus-outline-is-AccentColor.png

(In reply to Dão Gottwald [:dao] from comment #12)

Anna, do you know if this is still an issue? Has anything changed from when you reported this?

It is using var(--focus-outline-color) now that resolves to the AccentColor token. It is consistent across the Bookmarks panel but it is not Text color (would be white in my Win 11 Night Sky HCM where purple is the accent color).

I'll defer to Morgan and Jules if this is an acceptable approach.

Comment 14

[Jules Simplicio [:jules]]

I'll lean on Morgan here as far as what value is preferred, and then we can try to set this up properly with tokens if AccentColor is not it

Comment 15

[Dão Gottwald [:dao]]

Downgrading this further given comment 13.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the accessibility severity is higher, .
:dao, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 17

[Morgan Reschenberg [:morgan]]

(In reply to Anna Yeddi [:ayeddi] from comment #13)

Created attachment 9358693 [details]
Win11-HCM-Bookmarks-Focus-outline-is-AccentColor.png

(In reply to Dão Gottwald [:dao] from comment #12)

Anna, do you know if this is still an issue? Has anything changed from when you reported this?

It is using var(--focus-outline-color) now that resolves to the AccentColor token. It is consistent across the Bookmarks panel but it is not Text color (would be white in my Win 11 Night Sky HCM where purple is the accent color).

I'll defer to Morgan and Jules if this is an acceptable approach.

This is fine for now, though I'm surprised this wasn't fixed as a part of bug 1791024 🤔
Are we styling this focus ring manually?