Closed Bug 1755827 Opened 2 years ago Closed 2 years ago

nsIMsgFolder.generateUniqueSubfolderName returns prefix0 even when prefix is available

Categories

(MailNews Core :: Backend, enhancement)

enhancement

Tracking

(thunderbird_esr91 wontfix)

RESOLVED FIXED
99 Branch
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: rnons, Assigned: rnons)

Details

Attachments

(1 file)

As a result, sometimes we use ContainsChildNamed + generateUniqueSubfolderName, when generateUniqueSubfolderName should be enough. An example: https://searchfox.org/comm-central/rev/247aabc42ff6cdc3aace062b5fbdeac0774c4e8c/mailnews/import/src/nsImportMail.cpp#718,721

Will send a patch soon.

Assignee: nobody → remotenonsense
Status: NEW → ASSIGNED
Target Milestone: --- → 99 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7136e03da5c9
Return prefix instead of prefix0 in nsIMsgFolder.generateUniqueSubfolderName. r=benc

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Sorry, I just realized some tests depend on the old behavior. If only test_ThunderbirdProfileImporter.js fails, then no need to backout, I will send a patch to bug 1720042 soon. Thanks.

Seems only that yes. I'll disable this test so the tree's not too yellow.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/b1d1c40a3867
disable test_mergeLocalFolders until we get it fixed. rs=me
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: