1755922 - Hide app on mac via Command H does not work

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[punkerben]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:97.0) Gecko/20100101 Firefox/97.0

Steps to reproduce:

Command H to Hide Thunderbird in v98.0b2 (64-bit)

Actual results:

OS Menu UI acted like it was clicked but app was not hide.

Expected results:

Thunderbird should have be hidden, note: normal Thunderbird menu > Hide Thunderbird is still working.

Comment 1

[u597032]

Is this a bug in Thunderbird or in the OS?

Comment 2

[Wayne Mery (:wsmwk)]

With 98.0b2, It does work via menu. I agree Command H does not work. It does work with Firefox 98.0b4. So I assume this is not an OS issue, and specific to Thunderbird.

I do not know at when this first occurred.

Comment 3

[punkerben]

(In reply to Wayne Mery (:wsmwk) from comment #2)

With 98.0b2, It does work via menu. I agree Command H does not work. It does work with Firefox 98.0b4. So I assume this is not an OS issue, and specific to Thunderbird.

I do not know at when this first occurred.

Yes this is not a MacOS bug. This is also not a Firefox bug, it is a Thunderbird bug.
It is still in the daily build v99.0a1…

Comment 5

[Alessandro Castellani [:aleca]]

I'll try to fix this since it's very annoying.

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: Bug 1755922 - [macOS] Fix internal shortcuts not firing due to missing command attribute. r=Paenglab

Comment 7

[Alessandro Castellani [:aleca]]

This patch fixes it.
We were missing the internal="true" attribute for those system keys that don't use a command attribute, and are handled by the cocoa code.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ea6820168d29
[macOS] Fix internal shortcuts not firing due to missing command attribute. r=Paenglab

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9272243 [details]
Bug 1755922 - [macOS] Fix internal shortcuts not firing due to missing command attribute. r=Paenglab

[Approval Request Comment]
Keyboard shortcuts not working as expected on macOS.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9272243 [details]
Bug 1755922 - [macOS] Fix internal shortcuts not firing due to missing command attribute. r=Paenglab

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 100.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/8dd71dff41fb