1755939 - Different default actions for xml/svg for improvements on/off depends on FX version starting point

Status: NEW

(Firefox :: File Handling, defect, P5)

Description

[Adrian Florinescu [:aflorinescu]]

(In reply to :Gijs (away until Feb 21; he/him) from comment #22)

Expected (post-patch): we should save to disk by default (with the improvements pref on; with it off, a dialog will show up with the "save to disk" item pre-selected)

a. For the main update path Fx 97(-- bug 1753004) to Fx 99(++ bug 1753004), the default action for svg/xml will be and remain save, regardless of the value of the improve preference.
b. If the update path is done starting from Firefox version that already contains bug 1753004, the default actions will be correctly switched betwen save - improvements pref on and ask - improvements pref off.

Looking at the handler.json differences betwen Fx97 and Fx99 (or containing bug 175300), the handler.json created in Fx99 (or containing bug 175300) doesn't have entries for xml/svg, while the Fx97(or version which does not contain bug 175300) has entries for xml/svg, which implies that we do the default action switch based on improvements preference for svg/xml from code in absence of said entries, which won't be able to with the main update path(97->98) we're going to have once Fx98 graduates to release, since all Fx97 will have values for xml/svg.

Comment 1

[Adrian Florinescu [:aflorinescu]]

@Molly, since Gijs seems to be PTO atm, could you take a look over this, I'm uncertain what severity to set and if this should block the uplift for bug 1753004.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

If I understand this properly, it doesn't appear to be a blocker for us, because SVG/XML never end up in the opening automatically state in any case, and because we're ending up leaving things in something very close to the state that we would be trying to migrate to. Do I have that right?

Comment 3

[Adrian Florinescu [:aflorinescu]]

(In reply to Molly Howell (she/her) [:mhowell] from comment #2)

If I understand this properly, it doesn't appear to be a blocker for us, because SVG/XML never end up in the opening automatically state in any case, and because we're ending up leaving things in something very close to the state that we would be trying to migrate to. Do I have that right?

When you rephrase it this way, I can't push for a higher priority/severity for this. Indeed this issue would become an issue if we end up shipping downloads improvements then turning it off again and most likely even then it would be a small % that would actually notice it. For all intents and purposes, shipping download improvements would probably make this issue irelevant, hence let's go with S4.