1755951 - Prepare for the enabling of eslint on debugger tests

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1755907 is going to apply all necessary fix to make the test pass all eslint checks.
But there is some preliminary work to be done before being able to run eslint.

First, we should setup a valid eslintrc.js.
Then, we should start using the right import-symbols instruction in head.js/helpers.js/...

Let's try to do that before doing the massive eslint fixes in order to facilitate the review.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1755951 - [devtools] Prepare for the enabling of eslint on debugger tests.

After this patch, we only need to remove the ignore from /.eslintignore.

My goal originaly was to simply add import-globals-from comments in helpers.js
But because of cross dependencies between head.js and helpers.js, it wasn't so trivial.
I first tried to merge them into a unique head.js, but the EXAMPLE_URL symbol
should not be imported by tests external to the debugger.
So I aligned debugger to the common practice of naming the shared head file... shared-head.js!
Like the inspector is doing.
I also merged helpers/context.js into shared-head.js to simplify things a bit.

Because of that I had to tweak many tests outside of the debugger.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/124fb7aebc89
[devtools] Prepare for the enabling of eslint on debugger tests. r=nchevobbe

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/124fb7aebc89