1755996 - Add a pref to enable removal of search engine infobar

Status: VERIFIED FIXED

(Firefox :: Search, task, P1)

Comment 1

[Mandy Cheang [:mcheang][she/her]]

I'm adding a pref for the removal of search engine infobar. The infobar will be place behind this pref.

This pref is also used to disabled the infobar for certain tests that try to access it outside of search directory and anywhere else where it's unnecessary to have the infobar pop up.

Comment 2

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1755996 - Add pref for removal of search engine infobar. r?standard8

Comment 3

[Mandy Cheang [:mcheang][she/her]]

Comment on attachment 9264431 [details]
Bug 1755996 - Add pref for removal of search engine infobar. r?standard8

Beta/Release Uplift Approval Request

• User impact if declined: The patch adds a pref for the search engine removal info bar. The pref is turned on by default.
  The intention of this pref is to disable the infobar for certain tests that don't need it and enable the infobar for other tests that need it.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: The Search Engine Removal Info bar should not show up when:

• Default engine has changed and user's metadata (locale and region) is changed
• When the pref is turned off

The Infobar should show up when:

• Default engine has changed and user's metadata (locale and region) is unchanged
• When the pref is turned on

Overall steps to reproduce and test this patch are the same steps that Cristian, Adrian, and Vlad have been using for Bug 1748933 with the addition of browser.search.removeEngineInfobar.enabled pref that they can turn on or off.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is not risky because the code has automated XPCShell test that was added previously. Since the pref is turned on by default, it should not change the behaviour of the infobar. Turning on and off the pref was verified in the testing environment to be working correctly.
• String changes made/needed:

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46921ae274bc
Add pref for removal of search engine infobar. r=Standard8

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/46921ae274bc

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9264431 [details]
Bug 1755996 - Add pref for removal of search engine infobar. r?standard8

Approved for 98 beta 7, thanks.

Comment 7

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/8d73a93a547f

Comment 8

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

This issue was verified using Windows 10x64, macOS 12 and Ubuntu 20 using 98.0b7 and 99.0a1.
Verification coverage was done as part of the https://testrail.stage.mozaws.net/index.php?/plans/view/53723 test run.