[wpt-sync] Sync PR 32888 - [FlexNG] FlexLine cross axis offset and row expansion
Categories
(Core :: Layout, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 32888 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/32888
Details from upstream follow.
Alison Maher <almaher@microsoft.com> wrote:
[FlexNG] FlexLine cross axis offset and row expansion
Store the flex line cross_axis_offset on the FlexLine so that we
know the block-offset of flex rows.This CL uses cross_axis_offset when a row breaks before so that the
row expands by the correct offset.virtual/layout_ng_flex_frag/external/wpt/css/css-break/flexbox/multi-line-row-flex-fragmentation-016.html
is now failing because we currently set the item offset to 0 if it
broke before. The item had a top-margin that is no longer taken into
account during the expansion, and because the top-margin gets dropped
later, the next row appears to get the wrong offset. This will be
fixed in a future CL.Bug: 660611
Change-Id: Iff879a2186f60435aeb93a3ecdafd6cb4c5c7938Reviewed-on: https://chromium-review.googlesource.com/3387628
WPT-Export-Revision: 9dfcc44541d92a499560aad2519b2744d92270e7
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests
Status Summary
Firefox
FAIL: 2
Chrome
FAIL: 2
Safari
FAIL: 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/css/css-break/flexbox/multi-line-row-flex-fragmentation-029.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-030.html: FAIL (Chrome: FAIL, Safari: FAIL)
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7dbc36473eea
https://hg.mozilla.org/mozilla-central/rev/a6bb544321dc
Description
•