Open Bug 1756025 Opened 2 years ago Updated 2 years ago

obj/static-analysis/compile_commands.json is sometimes not updated

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P2)

Tracking

(firefox-esr91 unaffected, firefox99 wontfix, firefox100 wontfix, firefox101 fix-optional)

Tracking Status
firefox-esr91 --- unaffected
firefox99 --- wontfix
firefox100 --- wontfix
firefox101 --- fix-optional

People

(Reporter: saschanaz, Unassigned)

References

(Regression)

Details

(Keywords: regression)

I had to remove and rerun static-analysis check to refresh the file and get dom/streams included (which is behind a build flag and is recently enabled by default, bug 1752206).

Flags: needinfo?(bpostelnicu)

What do you mean? Could you please details more your issue and the environment where it occur?

Flags: needinfo?(bpostelnicu) → needinfo?(krosylight)
  1. Get a mozconfig with --disable-dom-streams
  2. ./mach build && ./mach static-analysis check dom/abort
  3. Remove --disable-dom-streams from the config
  4. ./mach build && ./mach static-analysis check dom/streams
  5. Check obj/static-analysis/compile_commands.json

Last time I tried this, the file didn't include any file in dom/streams.

Edit: Actually it wasn't the config that was edited, it was the moz.configure. Not sure that can cause any difference here, though.

Flags: needinfo?(krosylight)

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(bpostelnicu)
Regressed by: 1752206

I think it's a regression of bug 1756025.

Flags: needinfo?(bpostelnicu)

:mgaudet, since you are the author of the regressor, bug 1752206, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mgaudet)
Severity: -- → S1
Priority: -- → P1
Severity: S1 → S2
Priority: P2 → --

Not sure how bug 1756025 can cause this? I'd rather say it discovered the issue...

It was a copy and paste error, I wanted to paste bug 1752206.

Priority: -- → P2

Oh sorry, I was to say bug 1752206. That just enabled a flag, and doing so shouldn't cause this kind of issue.

Flags: needinfo?(mgaudet)

Set release status flags based on info from the regressing bug 1752206

Severity: S2 → S3
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.