Remove `AudioTrackSet` in TestAudioTrackGraph
Categories
(Core :: Audio/Video: MediaStreamGraph, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: chunmin, Assigned: chunmin)
Details
Attachments
(3 files)
Removing the AudioTrackSet can reduce the complexity of adding tests for the non-native input that we will create in bug 1238038.
AudioTrackSet are mainly used to test SetRequestedInputChannelCount. We have ForwardedInputTrack in AudioTrackSet, and it will be used as the MediaTrackGraph's output track, which will affect the output channel count of the MediaTrackGraph. If the output channel count changes, it will result in a GraphDriver switching. However, we only care about the input channel count when testing SetRequestedInputChannelCount. There is no need to take care of the unrelated property and have an unnecessary maintenance burden.
| Assignee | ||
Comment 1•4 years ago
|
||
| Assignee | ||
Comment 2•4 years ago
|
||
Removing the AudioTrackSet can reduce the complexity of adding tests for
the non-native input that we will create in bug 1238038.
AudioTrackSet are mainly used to test SetRequestedInputChannelCount.
We have ForwardedInputTrack in AudioTrackSet, and it will be used as the
MediaTrackGraph's output track, which will affect the output channel
count of the MediaTrackGraph. If the output channel count changes, it
results in a GraphDriver switching. However, we only care about the
input channel count when testing SetRequestedInputChannelCount. There
is no need to take care of the unrelated property and have an
unnecessary maintenance burden.
Depends on D139085
Updated•4 years ago
|
| Assignee | ||
Comment 3•4 years ago
|
||
Depends on D139085
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c8d705fd5799
https://hg.mozilla.org/mozilla-central/rev/6e53ba7b03f1
https://hg.mozilla.org/mozilla-central/rev/a7527d5a87be
Description
•