Closed Bug 1756077 Opened 4 years ago Closed 4 years ago

Remove `AudioTrackSet` in TestAudioTrackGraph

Categories

(Core :: Audio/Video: MediaStreamGraph, task, P1)

task

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

Details

Attachments

(3 files)

Removing the AudioTrackSet can reduce the complexity of adding tests for the non-native input that we will create in bug 1238038.

AudioTrackSet are mainly used to test SetRequestedInputChannelCount. We have ForwardedInputTrack in AudioTrackSet, and it will be used as the MediaTrackGraph's output track, which will affect the output channel count of the MediaTrackGraph. If the output channel count changes, it will result in a GraphDriver switching. However, we only care about the input channel count when testing SetRequestedInputChannelCount. There is no need to take care of the unrelated property and have an unnecessary maintenance burden.

Removing the AudioTrackSet can reduce the complexity of adding tests for
the non-native input that we will create in bug 1238038.

AudioTrackSet are mainly used to test SetRequestedInputChannelCount.
We have ForwardedInputTrack in AudioTrackSet, and it will be used as the
MediaTrackGraph's output track, which will affect the output channel
count of the MediaTrackGraph. If the output channel count changes, it
results in a GraphDriver switching. However, we only care about the
input channel count when testing SetRequestedInputChannelCount. There
is no need to take care of the unrelated property and have an
unnecessary maintenance burden.

Depends on D139085

Attachment #9264484 - Attachment description: Bug 1756077 - Correct annotation → WIP: Bug 1756077 - Correct annotation

Depends on D139085

Attachment #9264485 - Attachment description: Bug 1756077 - Remove AudioTrackSet → WIP: Bug 1756077 - Remove AudioTrackSet and rework related tests
Attachment #9264484 - Attachment description: WIP: Bug 1756077 - Correct annotation → Bug 1756077 - Correct annotation
Attachment #9264704 - Attachment description: WIP: Bug 1756077 - Use explicit type → Bug 1756077 - Use explicit type
Attachment #9264485 - Attachment description: WIP: Bug 1756077 - Remove AudioTrackSet and rework related tests → Bug 1756077 - Remove AudioTrackSet and rework related tests
Attachment #9264484 - Attachment description: Bug 1756077 - Correct annotation → Bug 1756077 - Correct annotations
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: