Closed Bug 1756182 Opened 2 years ago Closed 2 years ago

Reset actions state between tests

Categories

(Testing :: web-platform-tests, defect)

Product:
Testing
Component:
web-platform-tests
Version:
Default
Type:
defect

Tracking

(firefox104 fixed)

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: jgraham, Assigned: jgraham)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1756182 - Ensure we reset actions state before using them in a test,
48 bytes, text/x-phabricator-request
Details | Review

If one testdriver test did a pointerDown action then that state could persist into the following test, unless we explicitly call release actions. So we should make sure to do that before using any actions for the first time in a test.

This prevents actiosn state set up in one test leaking into subsequent tests.

Assignee: nobody → james
Status: NEW → ASSIGNED

The severity field is not set for this bug.
:jgraham, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(james)
Severity: -- → S3
Flags: needinfo?(james)
Attachment #9264568 - Attachment description: Bug 1756182 - Ensure we reset actions state before using them in a test, → Bug 1756182 - Ensure we reset actions state before using them in a test,
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/60ee209b5c23
Ensure we reset actions state before using them in a test, r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34805 for changes under testing/web-platform/tests

Backed out for causing mutiple wpt failures.

Failure line 1 : TEST-UNEXPECTED-FAIL | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse | Inner frame mouse pointerover's button is -1 when mouse buttons are in released state. - assert_equals: Button attribute is -1 expected -1 but got 0
Failure log 1

Failure line 2 : TEST-UNEXPECTED-OK | /visual-viewport/scroll-event-order.html | expected ERROR
Failure log 2

Push with failures

Backout link

Failure 1

[task 2022-07-12T12:48:55.403Z] 12:48:55     INFO - TEST-START | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse
[task 2022-07-12T12:48:55.779Z] 12:48:55     INFO - {'actions': [{'type': 'none', 'actions': [{'type': 'pause', 'duration': 16}, {'type': 'pause', 'duration': 16}, {'type': 'pause', 'duration': 16}], 'id': '0'}, {'type': 'pointer', 'actions': [{'type': 'pointerMove', 'x': 0, 'y': 0, 'origin': {'element-6066-11e4-a52e-4f735466cecf': '3c2aabc8-87da-4f74-b1f2-d65d8d5edc9d'}}, {'type': 'pointerDown', 'button': 0}, {'type': 'pointerUp', 'button': 0}], 'parameters': {'pointerType': 'mouse'}, 'id': 'mousePointer1'}]}
[task 2022-07-12T12:48:55.887Z] 12:48:55     INFO - {'actions': [{'type': 'none', 'actions': [{'type': 'pause', 'duration': 16}], 'id': '1'}, {'type': 'pointer', 'actions': [{'type': 'pointerMove', 'x': 0, 'y': 0, 'origin': 'viewport'}], 'parameters': {'pointerType': 'mouse'}, 'id': 'mousePointer1'}]}
[task 2022-07-12T12:48:55.963Z] 12:48:55     INFO - {'actions': [{'type': 'none', 'actions': [{'type': 'pause', 'duration': 16}, {'type': 'pause', 'duration': 16}, {'type': 'pause', 'duration': 16}], 'id': '2'}, {'type': 'pointer', 'actions': [{'type': 'pointerMove', 'x': 0, 'y': 0, 'origin': {'element-6066-11e4-a52e-4f735466cecf': '5acbdc59-bc3c-4461-bf35-96b089d39dcd'}}, {'type': 'pointerDown', 'button': 0}, {'type': 'pointerUp', 'button': 0}], 'parameters': {'pointerType': 'mouse'}, 'id': 'mousePointer1'}]}
[task 2022-07-12T12:48:56.063Z] 12:48:56     INFO - {'actions': [{'type': 'none', 'actions': [{'type': 'pause', 'duration': 16}], 'id': '3'}, {'type': 'pointer', 'actions': [{'type': 'pointerMove', 'x': 0, 'y': 0, 'origin': 'viewport'}], 'parameters': {'pointerType': 'mouse'}, 'id': 'mousePointer1'}]}
[task 2022-07-12T12:48:56.390Z] 12:48:56     INFO - 
[task 2022-07-12T12:48:56.390Z] 12:48:56     INFO - TEST-FAIL | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse |  mouse pointerleave.fromElement value is null. - assert_equals: fromElement attribute value expected (object) null but got (undefined) undefined
[task 2022-07-12T12:48:56.390Z] 12:48:56     INFO - check_PointerEvent/</<@http://web-platform.test:8000/pointerevents/pointerevent_support.js:83:30
[task 2022-07-12T12:48:56.390Z] 12:48:56     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2590:25
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - check_PointerEvent/<@http://web-platform.test:8000/pointerevents/pointerevent_support.js:82:17
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - check_PointerEvent@http://web-platform.test:8000/pointerevents/pointerevent_support.js:57:7
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - checkPointerEventAttributes@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:80:35
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - run/</<@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:110:52
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - TEST-FAIL | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse |  mouse pointerleave.toElement attribute exists - assert_true: toElement attribute in pointerleave event expected true got false
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - check_PointerEvent/</<@http://web-platform.test:8000/pointerevents/pointerevent_support.js:65:24
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2590:25
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - check_PointerEvent/<@http://web-platform.test:8000/pointerevents/pointerevent_support.js:64:13
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - check_PointerEvent@http://web-platform.test:8000/pointerevents/pointerevent_support.js:57:7
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - checkPointerEventAttributes@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:80:35
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - run/</<@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:110:52
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - TEST-PASS | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse |  mouse pointerleave.toElement is readonly 
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - TEST-FAIL | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse |  mouse pointerleave.toElement IDL type object (JS type was undefined) - assert_true: toElement attribute of type object expected true got false
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - check_PointerEvent/</<@http://web-platform.test:8000/pointerevents/pointerevent_support.js:77:24
[task 2022-07-12T12:48:56.391Z] 12:48:56     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2590:25
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - check_PointerEvent/<@http://web-platform.test:8000/pointerevents/pointerevent_support.js:76:13
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - check_PointerEvent@http://web-platform.test:8000/pointerevents/pointerevent_support.js:57:7
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - checkPointerEventAttributes@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:80:35
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - run/</<@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:110:52
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - TEST-FAIL | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse |  mouse pointerleave.toElement value is null. - assert_equals: toElement attribute value expected (object) null but got (undefined) undefined
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - check_PointerEvent/</<@http://web-platform.test:8000/pointerevents/pointerevent_support.js:83:30
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2590:25
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - check_PointerEvent/<@http://web-platform.test:8000/pointerevents/pointerevent_support.js:82:17
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - check_PointerEvent@http://web-platform.test:8000/pointerevents/pointerevent_support.js:57:7
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - checkPointerEventAttributes@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:80:35
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - run/</<@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:110:52
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - TEST-PASS | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse |  mouse pointerleave.pressure value is valid 
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - TEST-PASS | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse |  mouse pointerleave properties for pointerType = mouse 
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - TEST-PASS | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse |  mouse pointerleave.isPrimary attribute is correct. 
[task 2022-07-12T12:48:56.392Z] 12:48:56     INFO - TEST-PASS | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse |  mouse pointerleave.pointerId should be the same as previous pointer events for this active pointer. 
[task 2022-07-12T12:48:56.393Z] 12:48:56     INFO - TEST-PASS | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse | Inner frame  mouse pointerover's type should be pointerover 
[task 2022-07-12T12:48:56.393Z] 12:48:56     INFO - TEST-UNEXPECTED-FAIL | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse | Inner frame  mouse pointerover's button is -1 when mouse buttons are in released state. - assert_equals: Button attribute is -1 expected -1 but got 0
[task 2022-07-12T12:48:56.393Z] 12:48:56     INFO - checkPointerEventAttributes/<@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:59:38
[task 2022-07-12T12:48:56.393Z] 12:48:56     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2590:25
[task 2022-07-12T12:48:56.393Z] 12:48:56     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2022-07-12T12:48:56.393Z] 12:48:56     INFO - checkPointerEventAttributes@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:58:25
[task 2022-07-12T12:48:56.393Z] 12:48:56     INFO - run/</<@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:119:52
[task 2022-07-12T12:48:56.395Z] 12:48:56     INFO - 
[task 2022-07-12T12:48:56.395Z] 12:48:56     INFO - TEST-UNEXPECTED-FAIL | /pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse | Inner frame  mouse pointerover's buttons is 0 when mouse buttons are in released state. - assert_equals: Buttons attribute is 0 expected 0 but got 1
[task 2022-07-12T12:48:56.395Z] 12:48:56     INFO - checkPointerEventAttributes/<@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:62:38
[task 2022-07-12T12:48:56.395Z] 12:48:56     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2590:25
[task 2022-07-12T12:48:56.395Z] 12:48:56     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2022-07-12T12:48:56.395Z] 12:48:56     INFO - checkPointerEventAttributes@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:61:25
[task 2022-07-12T12:48:56.395Z] 12:48:56     INFO - run/</<@http://web-platform.test:8000/pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse:119:52

Failure 2

[task 2022-07-12T13:00:36.299Z] 13:00:36     INFO - TEST-START | /visual-viewport/scroll-event-order.html
[task 2022-07-12T13:00:36.303Z] 13:00:36     INFO - Closing window 5817880e-391d-49d5-b5fd-c819acbe4e44
[task 2022-07-12T13:00:36.316Z] 13:00:36     INFO - Closing window 4772698f-4148-4c74-9daf-6c99231590d3
[task 2022-07-12T13:00:36.432Z] 13:00:36     INFO - {'actions': [{'type': 'none', 'actions': [{'type': 'pause', 'duration': 16}, {'type': 'pause', 'duration': 16}, {'type': 'pause', 'duration': 16}, {'type': 'pause', 'duration': 16}], 'id': '0'}, {'type': 'pointer', 'actions': [{'type': 'pointerMove', 'x': 631, 'y': 419, 'origin': 'viewport'}, {'type': 'pointerDown', 'button': 0}, {'type': 'pointerMove', 'x': 631, 'y': 369, 'origin': 'viewport'}, {'type': 'pointerUp', 'button': 0}], 'parameters': {'pointerType': 'touch'}, 'id': 'finger1'}, {'type': 'pointer', 'actions': [{'type': 'pointerMove', 'x': 631, 'y': 519, 'origin': 'viewport'}, {'type': 'pointerDown', 'button': 0}, {'type': 'pointerMove', 'x': 631, 'y': 569, 'origin': 'viewport'}, {'type': 'pointerUp', 'button': 0}], 'parameters': {'pointerType': 'touch'}, 'id': 'finger2'}]}
[task 2022-07-12T13:00:36.563Z] 13:00:36     INFO - TEST-UNEXPECTED-OK | /visual-viewport/scroll-event-order.html | expected ERROR
[task 2022-07-12T13:00:36.563Z] 13:00:36     INFO - TEST-INFO expected ERROR | took 270ms
[task 2022-07-12T13:00:36.576Z] 13:00:36     INFO - PID 1144 | 1657630836575	Marionette	INFO	Stopped listening on port 50027
[task 2022-07-12T13:00:36.663Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1b97b900 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3587
[task 2022-07-12T13:00:36.679Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1b97b900 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1791
[task 2022-07-12T13:00:36.679Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1ccf0600 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3587
[task 2022-07-12T13:00:36.679Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1ccf0600 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1791
[task 2022-07-12T13:00:36.679Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1f9c2500 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3587
[task 2022-07-12T13:00:36.679Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1f9c2500 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1791
[task 2022-07-12T13:00:36.688Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1b97b900 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1826
[task 2022-07-12T13:00:36.688Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1b97b900 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3689
[task 2022-07-12T13:00:36.690Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1ccf0600 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1826
[task 2022-07-12T13:00:36.690Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1ccf0600 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3689
[task 2022-07-12T13:00:36.691Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1f9c2500 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1826
[task 2022-07-12T13:00:36.692Z] 13:00:36     INFO - PID 1144 | [Parent 4496, Main Thread] WARNING: ContentParent: id=1f9c2500 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3689
[task 2022-07-12T13:00:37.598Z] 13:00:37     INFO - Browser exited with return code 0
[task 2022-07-12T13:00:37.602Z] 13:00:37     INFO - Closing logging queue
[task 2022-07-12T13:00:37.603Z] 13:00:37     INFO - queue closed
[task 2022-07-12T13:00:37.735Z] 13:00:37     INFO - Application command: Z:\task_165762841631430\build\application\firefox\firefox.exe -marionette about:blank --wait-for-browser -profile C:\Users\task_165762841631430\AppData\Local\Temp\tmpwzrxtz3b
[task 2022-07-12T13:00:37.747Z] 13:00:37     INFO - PID 3180 | 1657630834101	Marionette	INFO	Marionette enabled
[task 2022-07-12T13:00:37.750Z] 13:00:37     INFO - PID 3180 | 1657630834104	Marionette	INFO	Listening on port 50094
[task 2022-07-12T13:00:37.751Z] 13:00:37     INFO - PID 3180 | console.warn: SearchSettings: "get: No settings file exists, new profile?" (new NotFoundError("Could not open the file at C:\\Users\\task_165762841631430\\AppData\\Local\\Temp\\tmp9d71cge6\\search.json.mozlz4", (void 0)))
[task 2022-07-12T13:00:37.752Z] 13:00:37     INFO - Starting runner
[task 2022-07-12T13:00:38.924Z] 13:00:38     INFO - TEST-START | /visual-viewport/viewport-no-resize-event-on-overflow-recalc.html

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/48dac2cac9ee
Ensure we reset actions state before using them in a test, r=webdriver-reviewers,whimboo
Upstream PR merged by moz-wptsync-bot
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/040f5dcacb12
Ensure we reset actions state before using them in a test, r=webdriver-reviewers,whimboo
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

https://hg.mozilla.org/mozilla-central/rev/040f5dcacb12

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: