Closed Bug 1756217 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 32906 - [FlexNG] Column balancing with forced breaks

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32906 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32906
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Column balancing with forced breaks

Because we didn't handle expansions when breaking before during the
initial column balancing pass, we could end up with items or rows
having a negative offset resulting in an inaccurate column block
size.

Move the expansion handling from where the break before is added to the
next column. We know the consumed block size in the subsequent column,
and the consumed block size can be used to determine the amount to
expand by, even if the fragmentainer block size is unknown.

Bug: 660611
Change-Id: I1309b3906126fc9a838634596cd6280241d5efee
Reviewed-on: https://chromium-review.googlesource.com/3475053
WPT-Export-Revision: 70895e23d0ad35b1b1ad1fa5adb2cecbcbbadb9d

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

FAIL: 2

Safari

FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-row-flex-fragmentation-031.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/single-line-column-flex-fragmentation-032.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ff5acbea3b7
[wpt PR 32906] - [FlexNG] Column balancing with forced breaks, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7a236e93d555
[wpt PR 32906] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3ff5acbea3b7
https://hg.mozilla.org/mozilla-central/rev/7a236e93d555

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.