1756264 - Colors indicated in graph legend are incorrect

Status: RESOLVED FIXED

(Socorro :: Webapp, defect, P2)

Description

[Ray Kraesig [:rkraesig]]

Attachment: Screenshot of relevant portion of graph

Seen at this crash-stats link, sorting by major version.

The legend indicates that green is 95; hovering over the green line indicates it's 91. (Other queries confirm that "91" is correct.)

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Huh. I have no idea when that broke. I'll look into it next week when I get a chance.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm going to unassign myself because I'm not going to get to this.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I thought I unassigned myself, but didn't. Oops.

Comment 4

[Eduardo Filho [:efilho]]

Attachment: pr 6139: bug 1756264: correct graph legend

Because Javascript doesn't guarantee the reading order will be the same as the insertion order for objects, the major version order for legend (array) and graph data (object) would not match sometimes. This was fixed by building the legend array along with lineDataArray, which contains graph data and is an array, which guarantees the reading order will be the same as insertion order.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

edugfilho merged PR #6139: "bug 1756264: correct graph legend" in 7d8c10d.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this to prod just now in bug #1787851. Marking as FIXED.