Closed Bug 1756328 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 32914 - Test webrtc/content-security-policy integration

Categories

(Core :: DOM: Security, task, P4)

Product:
Core
Component:
DOM: Security
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog])

Sync web-platform-tests PR 32914 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32914
Details from upstream follow.

Ian Denhardt <ian@zenhack.net> wrote:

Test webrtc/content-security-policy integration

...as specified in:

This is a work in progress; in particular:

  • Right now all of the "allow" tests fail with:
  ▶ ERROR [expected OK] /content-security-policy/webrtc/webrtc-allowed-nopolicy.html
  └   → Unhandled rejection: Unknown ufrag (3a846ca3)

If I silence that one rejection they pass (and the "blocked" tests still fail), but I don't know the right approach to make sure that event doesn't fire before we can handle it.

  • I'm very fuzzy on whether this is actually the right approach; right now this tries to monitor the ice agent's transitions and make sure it goes straight from new to failed, but my grasp of the intricacies of webrtc is still somewhat tenuous, so I would not be surprised if the logic for this was wrong in some critical way.

I would appreciate feedback.

cc: @jan-ivar @alvestrand @annevk @antosart

Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 1 subtests

Status Summary

Firefox

OK : 5
PASS: 3
FAIL: 2

Chrome

OK : 5
PASS: 3
FAIL: 2

Safari

OK : 5
PASS: 3
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/content-security-policy/webrtc/webrtc-blocked-explicit.html
webrtc blocked with an explicit webrtc blocked policy: FAIL (Chrome: FAIL, Safari: FAIL)
/content-security-policy/webrtc/webrtc-blocked-unknown.html
webrtc blocked with an unrecognized explicit webrtc policy: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d99c71c934d
[wpt PR 32914] - Test webrtc/content-security-policy integration, a=testonly
https://hg.mozilla.org/integration/autoland/rev/065edade2923
[wpt PR 32914] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5d99c71c934d
https://hg.mozilla.org/mozilla-central/rev/065edade2923

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.