Remove workaround of bug 1707959
Categories
(GeckoView :: General, task, P3)
Tracking
(firefox102 wontfix, firefox103 wontfix, firefox104 fixed)
People
(Reporter: m_kato, Assigned: pranshukumar1999)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=java])
Attachments
(1 file)
EdgeEffect.setType is removed by https://cs.android.com/android/_/android/platform/frameworks/base/+/b1aee44bea4b50a4e9b85e85212101a5c7280fd9 until GA. Android 12 doesn't have this, so we should remove the workaround of bug 1707959
|
Reporter | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 1•2 years ago
|
||
Please assign this bug to me.
|
|
Reporter | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
So I was going through the attached link and the conversation and I understand that Set TYPE_GLOWis point of concern here which I think is to be removed completely. Am I right? Need some insights.
|
|
Reporter | |
Comment 3•2 years ago
|
||
This bug is about https://searchfox.org/mozilla-central/rev/3cb31675aeffd10f1f6ae7c40e24b254da7798e5/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/OverscrollEdgeEffect.java#47-72. Although We added a workaround for Android-S (developer preview), "EdgeEffect.setType" is removed until Android 12 GA. So this code is unnecessary.
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
|
Assignee | |
Comment 5•2 years ago
|
||
Sir, I opened a PR by removing the same https://phabricator.services.mozilla.com/D151991.
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/ff0b0ef9b330 Removed Workaround of Bug1707959. r=m_kato,geckoview-reviewers
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
|
||
Comment 8•2 years ago
|
||
Thanks for the fix, Pranshu! This fix will be released in v104.
|
|
Assignee | |
Comment 9•2 years ago
|
||
Happy to contribute sir.
Description
•