Closed Bug 1756726 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 32949 - [FlexNG] Handle break-before/after: avoid for rows

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32949 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32949
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Handle break-before/after: avoid for rows

Add MovePastRowBreakPoint() and AttemptRowSoftBreak() to handle
further breaking scenarios for flex rows (including break-before/
break-after: avoid).

break-inside:avoid handling for rows was not added since that will be
handled at the item level.

Some follow-ups will be required, such as handling
IsBreakableAtStartOfResumedContainer() and PropagateSpaceShortage().

Bug: 660611
Change-Id: Ie2995d35880a7b632154386fe84c9bf4ad89b63e
Reviewed-on: https://chromium-review.googlesource.com/3482674
WPT-Export-Revision: 8041b0002494d86162e2a5dedea8301c31ccb014

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests

Status Summary

Firefox

PASS: 3
FAIL: 6

Chrome

PASS: 3
FAIL: 6

Safari

PASS: 3
FAIL: 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-row-flex-fragmentation-032.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-033.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-034.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-035.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/single-line-row-flex-fragmentation-019.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/single-line-row-flex-fragmentation-020.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/74b7a5dd7e7c [wpt PR 32949] - [FlexNG] Handle break-before/after: avoid for rows, a=testonly https://hg.mozilla.org/integration/autoland/rev/a35d44133106 [wpt PR 32949] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/74b7a5dd7e7c
https://hg.mozilla.org/mozilla-central/rev/a35d44133106

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.