1756757 - Cleanup debugger's shared-head test helpers

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

This file contains a few methods that aren't used.
Some others that are redundant with the one from the master devtools/client/test/shared-head.js
And yet others that could be clarified or remove for sparse usages.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1756757 - [devtools] Remove log method in debugger tests.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1756757 - [devtools] Remove unused function from debugger's shared-head.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1756757 - [devtools] Stop using isPaused from debugger test and clarify existing pause/resume helpers.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1756757 - [devtools] Remove assertEmptyLines being redundant with browser_dbg-breakable-lines.js test.

There was this unique check against non-breakable lines.
browser_dbg-breakable-lines.js now test this much more in depth.
This old unique assertion is not worth keeping.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1756757 - [devtools] Use wait instead of waitForTime.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1756757 - [devtools] Use waitFor instead of waitUntilPredicate.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec5e1b2b909c
[devtools] Remove log method in debugger tests. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/38614ed5eb95
[devtools] Remove unused function from debugger's shared-head. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a852ff5eb02b
[devtools] Stop using isPaused from debugger test and clarify existing pause/resume helpers. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/d20635b90025
[devtools] Remove assertEmptyLines being redundant with browser_dbg-breakable-lines.js test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/9ebd03ced039
[devtools] Use wait instead of waitForTime. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8e5f8934959d
[devtools] Use waitFor instead of waitUntilPredicate. r=nchevobbe

Comment 8

[Cristian Tuns]

Backed out for causing mochitest failures on browser_dbg-paused-overlay.js,browser_dbg-old-breakpoint.js

• Backout link
• Push with failures
• Failure Log
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-old-breakpoint.js | Test timed out

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db34b925e04a
[devtools] Remove log method in debugger tests. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/e55287171993
[devtools] Remove unused function from debugger's shared-head. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f7f539ec7339
[devtools] Stop using isPaused from debugger test and clarify existing pause/resume helpers. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/4a9cfba6611d
[devtools] Remove assertEmptyLines being redundant with browser_dbg-breakable-lines.js test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/9ff73c2724f9
[devtools] Use wait instead of waitForTime. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/fe4503df7819
[devtools] Use waitFor instead of waitUntilPredicate. r=nchevobbe

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/db34b925e04a
https://hg.mozilla.org/mozilla-central/rev/e55287171993
https://hg.mozilla.org/mozilla-central/rev/f7f539ec7339
https://hg.mozilla.org/mozilla-central/rev/4a9cfba6611d
https://hg.mozilla.org/mozilla-central/rev/9ff73c2724f9
https://hg.mozilla.org/mozilla-central/rev/fe4503df7819