1756795 - Explain in key properties what the (!) indicator means (advanced OpenPGP key configurations)

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert [:KaiE:]]

Originally in bug 1654893, and adjusted in bug 1753214, we added a special indicator for the OpenPGP key properties dialog.

An OpenPGP key is a flexible mix of multiple individual keys. Usually just 2 (one for signing, another one for encryption), but any number is possible.

Advanced users, who have created their secret/personal key outside of Thunderbird with different tools, may import a special combination key into Thunderbird, which only has the secret available for some of those keys.

To help advanced users, we had introduced a small visual indicator, to remind the user which secret keys are absent.

The indicator is (!) shown in front of the key type.

Because we had wanted this indicator on the stable branch, we didn't add a descriptive text at that time, and then it was forgotten.

An example screenshot is here: attachment 9264374 [details]

My simple suggestion is:

If at least one key has the (!), then show the following text underneath the table:
"For keys marked with (!) the secret key is not available."

(The text would not be shown if no keys need the (!) indicator.)

Comment 1

[Kai Engert [:KaiE:]]

Alessandro, do you think this approach is sufficient?

Comment 2

[Alessandro Castellani [:aleca]]

I think it might be fine as a temporary solution.
We will redesign this key properties dialog in the next cycle, so I think a quick fix to add a description is acceptable even if not optimal.
Thumbs up!

Please, use the tip-caption class on that element so it's styled like an helper description.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1756795 - Add a legend for the secret key missing indicator. r=aleca

Comment 4

[Kai Engert [:KaiE:]]

Attachment: two-sign-subkeys-second-sub-deleted-sec.asc

Comment 5

[Kai Engert [:KaiE:]]

Attachment: two-sign-all-pub.asc

Comment 6

[Kai Engert [:KaiE:]]

I've manually tested that the code behaves as intended.

If you'd like to test yourself, use openpgp key manager and:

• import secret key file two-sign-subkeys-second-sub-deleted-sec.asc (password: x)
• import public key file two-sign-all-pub.asc
• double-click key named two-sign-subkeys and open structure tab

You should see the new label.
Open any other regular key, and the label should be hidden.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7990d35558f2
Add a legend for the secret key missing indicator. r=aleca