1756805 - Pocket in about:welcome does not update after live language switching

Status: VERIFIED FIXED

(Core :: Internationalization, enhancement, P1)

Description

[Greg Tatum [:gregtatum]]

Attachment: image.png

If you download an es-ES browser, Pocket is not shown. However, if you download an en-US browser, and install an es-ES langpack, Pocket is still shown. It seems like this widget should key off of the langpack rather than the browser's built-in language.

This is even worse when switching from LTR to RTL, as the RTL view of pocket is broken. It appears if you restart the browser it correctly hides the view though.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: rtl

Here is the RTL view, which is showing English text going RTL.

Comment 2

[Greg Tatum [:gregtatum]]

Ok, looking into this a full restart seems to fix things, so I don't think the previous behavior is broken at all. The fix here for the new live language switching behavior is to listen for the "intl:app-locales-changed" event, and update the UI to hide non-supported locales.

• The decision on showing is made in ActivityStream.jsm#506
• The UI is specified as hidden in ActivityStream.jsm#147. This is "feeds.section.topstories.options"
• This pref is read in SectionsManager.jsm#59

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1756805 - Listen for locale changes for top stories; r?pdahiya,mardak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b574f396c035
Listen for locale changes for top stories; r=platform-i18n-reviewers,dminor

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b574f396c035

Comment 6

[Ardelean Oana, Desktop QA [:oardelean]]

This enhancement was implemented on Firefox 100 with the new Live Language feature. I verified this on Firefox 100.0b8(20220419190903) on Win10 64-bits, macOS 11 and Ubuntu 20.04; switching languages will automatically translate Pocket in about:welcome now.