1756816 - Change order of reps to speedup getRep

Status: ASSIGNED

(DevTools :: Object Inspector, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

getRep goes through a list of components (devtools/client/shared/components/reps/reps/rep.js#45-81 and check for each one if their supportObjects function returns true for a given grip.

The order in which reps are iterated is not optimal, and we could probably re-order them so we check the components that are most likely to be used first (String, Number, Grip, …)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1756816 - [devtools] Re-order Reps to speed up getRep. r=Honza.

This patch makes it so we iterate over the components that are most likely to
be used first (string, number, objects, …)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nchevobbe, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nicolas, can we land the patch? Or are there any blockers?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

I had to fix a few test failures, and I wanted to wait on my work to automatically generate stubs before landing it. This will also conflict with Bug 1759135, which I'd rather land first