Closed Bug 17569 Opened 20 years ago Closed 20 years ago

[DOGFOOD] Pressing <ENTER> key in Dialogues should equate to OK button


(Core :: XUL, defect, P3)






(Reporter: paulmac, Assigned: hangas)



(Whiteboard: [PDT-]RN may be fixed with other dialog fixes)

In many dialogues, there is an expectation that pressing Enter should be the
same as hitting the OK button. The wallet dialogues are one example of this. Let
me know if you need a list of dialogues.

To reproduce:

1. Goto Edit | Wallet | Change Password...
2. Type in a password and press <Enter>

Results: Nothing happens
Expected Results: Should act as if you pressed OK button

This is seen on all platforms 10/28 builds, and has been around since day 1.

I see this working on File - Open Web Location and File - Open but not on other
Assignee: davidm → sdagley
reassign to sdagley since this isn't working in any dialog ( alert or one with an
editfield). I am guessing something about our keybinding strategy has changed
since steve implemented his code. I think ender still sucks up metachars in
editfields so this bug might have to be reassigned before it is completely fixed.
The way that the Open Web Location works is a hack and should not be proprogated
The same sort of expectation exists for using the [ESC] key to get the
effect of clicking on the [Cancel] button. Support for this is also
spotty at present.
Summary: Pressing <ENTER> key in Dialogues should equate to OK button → [DOGFOOD] Pressing <ENTER> key in Dialogues should equate to OK button
Adding lchiang, scalkins,prass and amusil to CC as this affects IM team. Setting
to Dogfood for PDT review. It is very annoying to have to click on the OK button
when users are accustomed to the Enter key doing the same job in dialog boxes.
There are probably 2 different problems:

1) Keybinding is apparently flaky at the moment (although saari sez waterson's
checkin today may have addressed the major issues)

2) Many dialogs are not using Paul Hangas' dialog template which provides for
platform specific button placement and dialog default buttons
Whiteboard: [PDT-]RN
Putting on PDT- radar.  Fix not needed for dogfood.
Component: HTML Dialogs → XP Toolkit/Widgets
moving to xptoolkit so HTML dialogs component can be retired.
Target Milestone: M13
targetting p3 for m13
*** Bug 15852 has been marked as a duplicate of this bug. ***
Assignee: sdagley → hangas
Hangas asked for key behavior in dialog bugs to be sent his way...
Whiteboard: [PDT-]RN → [PDT-]RN may be fixed with other dialog fixes
<ENTER> is equating to the [OK] button in the "Open Web Location" and "Open
File" Dialogs, using the 1999-12-23-08-M13 nightly binary on Windows NT 4.0sp3
This may be no surprise given the contents of the Status Whiteboard.
This is not working for authentication dialogs (http://is).
spam: adding self to cc list, as this does affect some of my areas.
Closed: 20 years ago
Resolution: --- → FIXED
This bug is actually a duplicate of another bug that has been fixed.  Marking
this one fixed.  If there are still dialogs that have this problem please file
one bug for each dialog.
QA Contact: cpratt → sairuh
You need to log in before you can comment on or make changes to this bug.