Clean up `JoinNodeTransaction`
Categories
(Core :: DOM: Editor, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(3 files)
|
Assignee | |
Comment 1•2 years ago
|
||
For consistency with the other things in editor module, it should be "nodes"
rather than "node" since 2 nodes are joined by it.
|
|
Assignee | |
Comment 2•2 years ago
|
||
This patch renames members and variables in it not to use "left" and "right"
words to preparing to support both direction joining. So this patch does not
change any behavior.
Depends on D139715
|
|
Assignee | |
Comment 3•2 years ago
|
||
This push some post processing of joining nodes into JoinNodesTransaction and
HTMLEditor::DidJoinNodes() to make HTMLEditor::JoinNodesTransaction()
simpler and the new method does not use the "left"/"right" words at post
processing.
This changes the logic a bit so that it may change some behavior if web apps
uses some legacy mutation events, but it must be rare case because the other
browsers don't fire them synchronously.
Depends on D139716
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/7716ef075e84 part 1: Rename `JoinNodeTransaction` to `JoinNodesTransaction` r=m_kato https://hg.mozilla.org/integration/autoland/rev/2c26f3ae2371 part 2: Clean up `JoinNodesTransaction` members and variables r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/9a66f5ae4e02 part 3: Clean up `HTMLEditor::JoinNodesWithTransaction()` r=m_kato
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7716ef075e84
https://hg.mozilla.org/mozilla-central/rev/2c26f3ae2371
https://hg.mozilla.org/mozilla-central/rev/9a66f5ae4e02
Description
•