[Automated review] android-lints (Mozlint) warns about changes I haven't made
Categories
(Developer Infrastructure :: Lint and Formatting, defect, P3)
Tracking
(Not tracked)
People
(Reporter: mcomella, Unassigned)
Details
Phabricator URL: https://phabricator.services.mozilla.com/D139198
I receive a warning from android-lints:
Error mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:218
However, I made no changes to GeckoRuntimeSettings.java: it's likely this warning is present on mozilla-central but not in my change. For each commit in my change and for each update I make to my commits, I get a comment by reviewbot about this warning and it's time consuming to figure out whether or not it's caused by my change.
We should only warn about changes if they exist in the lines changed for the current commit.
|
||
Comment 1•3 years ago
|
||
The severity field is not set for this bug.
:andi, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Comment 2•3 years ago
|
||
Shouldn't this be flagged as warnings? Because they are flagged as errors they are displayed by the review bot even if they are not part of the patch.
|
|
||
Updated•3 years ago
|
|
||
Comment 3•3 years ago
|
||
(In reply to Andi [:andi] from comment #2)
Shouldn't this be flagged as warnings? Because they are flagged as errors they are displayed by the review bot even if they are not part of the patch.
Probably? There was no such thing as a lint warning when these Android lints were implemented, so it's entirely possible they need to be bumped.
|
|
||
Comment 4•3 years ago
|
||
The severity field is not set for this bug.
:ahal, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Comment 5•3 years ago
|
||
Just beware that warnings don't cause a backout.
But I'm a bit confused.. If this is an error but not caused by the patch, then how did it get into the tree without being backed out?
|
||
Updated•3 years ago
|
Description
•