1757126 - Cache AccessKey and KeyboardShortcut

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1757126 part 1: Remove RemoteAccessible::KeyboardShortcut.

KeyboardShortcut is only supported for XUL menu items.
XUL menu items can never be remote, so there's no point in querying this via IPDL.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1757126 part 2: Move KeyBinding to base Accessible header.

We'll need this to unify AccessKey and KeyboardShortcut.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1757126 part 3: Push AccessKey to the parent process cache.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1757126 part 4: Support AccessKey on cached RemoteAccessible.

1. Move AccessKey to base Accessible.
2. Retrieve AccessKey from the cache for RemoteAccessible.
3. Update XPCOM and platform specific code accordingly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d10b2dfdc99
part 1: Remove RemoteAccessible::KeyboardShortcut. r=morgan,ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/b0809e6a3de3
part 2: Move KeyBinding to base Accessible header. r=morgan
https://hg.mozilla.org/integration/autoland/rev/6ee5d245c2fc
part 3: Push AccessKey to the parent process cache. r=morgan
https://hg.mozilla.org/integration/autoland/rev/e57b1129fd48
part 4: Support AccessKey on cached RemoteAccessible. r=morgan

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages on xpcAccessible.cpp

Backout link

Push with failures

Failure log

There's a mochitest failure too: https://treeherder.mozilla.org/logviewer?job_id=384309912&repo=autoland&lineNumber=2408

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d817cc2fbb0
Backed out 4 changesets for causing build bustages on xpcAccessible.cpp CLOSED TREE

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaea79545fac
part 1: Remove RemoteAccessible::KeyboardShortcut. r=morgan,ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/23d1e1d348b6
part 2: Move KeyBinding to base Accessible header. r=morgan
https://hg.mozilla.org/integration/autoland/rev/8abe7062fd70
part 3: Push AccessKey to the parent process cache. r=morgan
https://hg.mozilla.org/integration/autoland/rev/67fe0f230d6d
part 4: Support AccessKey on cached RemoteAccessible. r=morgan

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/aaea79545fac
https://hg.mozilla.org/mozilla-central/rev/23d1e1d348b6
https://hg.mozilla.org/mozilla-central/rev/8abe7062fd70
https://hg.mozilla.org/mozilla-central/rev/67fe0f230d6d