Closed Bug 1757255 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32993 - [FlexNG] Flex row breaks when there is no container separation

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32993 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32993
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Flex row breaks when there is no container separation

Handle IsBreakableAtStartOfResumedContainer() for items in a row.
As a part of this CL, we now pass in a bool to
BreakBeforeChildIfNeeded() to tell whether the child is an item in a
row so that we only perform the code needed for such items. For
example, break-before/break-after values should have no effect on
row items (since that is taken care of by the row itself).

Note: multi-line-row-flex-fragmentation-041.tentative.html and
multi-line-row-flex-fragmentation-042.tentative.html worked previously
to this CL but were added to ensure those cases were working
without any additional handling at the row level.

Bug: 660611
Change-Id: I755428b5bf3749c21819ebfaca53efdb725f467a
Reviewed-on: https://chromium-review.googlesource.com/3491562
WPT-Export-Revision: a228185b7612bb7aa6be0ea758961e587a8bd4b0

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 2
FAIL: 2

Chrome

FAIL: 4

Safari

FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-row-flex-fragmentation-039.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-040.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a1f05d4306e [wpt PR 32993] - [FlexNG] Flex row breaks when there is no container separation, a=testonly https://hg.mozilla.org/integration/autoland/rev/4c2587a9b652 [wpt PR 32993] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8a1f05d4306e
https://hg.mozilla.org/mozilla-central/rev/4c2587a9b652

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.