Closed Bug 1757305 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 32997 - [block-in-inline] Fix hit-testing when inline box is not culled

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32997 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32997
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[block-in-inline] Fix hit-testing when inline box is not culled

This patch fixes hit-testing block-in-inline when the inline
box is not culled. This fixes not only for crbug.com/1300205,
but also failures of crrev.com/c/3486321 for crbug.com/1295183.

Two logic changes are included:

  1. Hit-testing should ignore opaque inline boxes. |IsOpaque|
    was added in r908729 crrev.com/c/3066831 because inline
    boxes that wraps block-in-inline are not visible to layout
    and paint except some paint effects.
  2. r925189 crrev.com/c/3181220 hit-tests block-backgrounds
    while in the foreground phase. This resulted ignoring
    floats, because floats are between foreground and block
    background. https://drafts.csswg.org/css2/#painting-order
    This patch reverts the change.

Bug: 1300205
Change-Id: Ie94df6092fe7d50599ab4f985233cf0dfa968efd

Reviewed-on: https://chromium-review.googlesource.com/3489020
WPT-Export-Revision: 733c092c47903455c4f427a44187a380c1109f6f

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS: 5

Chrome

OK : 1
PASS: 2
FAIL: 3

Safari

OK : 1
PASS: 5

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4da4d9c3b31d
[wpt PR 32997] - [block-in-inline] Fix hit-testing when inline box is not culled, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4da4d9c3b31d

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.