1757394 - [wpt-sync] Sync PR 33000 - Implement VideoTrackGenerator.mute attribute

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33000 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33000
Details from upstream follow.

Harald Alvestrand <[e-mail]> wrote:

Implement VideoTrackGenerator.mute attribute

This refactors VideoTrackGenerator to have a reference to the source,
and lets MediaStreamTrackGenerator take an injected source.

Bug: chromium:1300528
Change-Id: Ia8a97cd48aa8f1039ee10e8cf1b410ed33834abc
Reviewed-on: https://chromium-review.googlesource.com/3494784
WPT-Export-Revision: 8787e92e66d6db53e7345cc0eb8aa42541a99278

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 33000 applied with additional changes from upstream: 4ef0ce599886cb90e7dda113be9fdd421a5c8f20

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae6b8ecad9e5760460b4a2c284a9c4ce33e07283

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
FAIL: 8

Chrome

OK : 1
FAIL: 8

Safari

OK : 1
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/mediacapture-insertable-streams/VideoTrackGenerator.https.html
Tests that VideoTrackGenerator forwards frames to sink: FAIL (Chrome: FAIL, Safari: FAIL)
Tests that frames are actually rendered correctly in a stream used for a video element.: FAIL (Chrome: FAIL, Safari: FAIL)
Tests that frames are actually rendered correctly in a stream sent over a peer connection.: FAIL (Chrome: FAIL, Safari: FAIL)
Tests that frames are sent correctly with RTCRtpEncodingParameters.scaleResolutionDownBy.: FAIL (Chrome: FAIL, Safari: FAIL)
Tests that creating a VideoTrackGenerator works as expected: FAIL (Chrome: FAIL, Safari: FAIL)
Tests that VideoFrames are destroyed on write.: FAIL (Chrome: FAIL, Safari: FAIL)
Mismatched frame and generator kind throws on write.: FAIL (Chrome: FAIL, Safari: FAIL)
Tests that VideoTrackGenerator forwards frames only when unmuted: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/accf2658dc20
[wpt PR 33000] - Implement VideoTrackGenerator.mute attribute, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a467c0d6dc3c
[wpt PR 33000] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6246bed75053
[wpt PR 33000] - Implement VideoTrackGenerator.mute attribute, a=testonly
https://hg.mozilla.org/integration/autoland/rev/597947fdf53c
[wpt PR 33000] - Update wpt metadata, a=testonly

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6246bed75053
https://hg.mozilla.org/mozilla-central/rev/597947fdf53c