1757407 - Move l10nregistry to mozilla-central

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Dan Minor [:dminor]]

Currently l10nregistry development occurs at https://github.com/mozilla/l10nregistry-rs. We plan to move development to mozilla-central to make development and the code review process easier. The code seems quite specific to Mozilla's needs and there are not any external users that we currently know about.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1757407 - Add l10nregistry-rs to mozilla-central; r=#platform-i18n-reviewers

This is a copy of git revision 9da98c6e5325a5f2997191727eaa82c0ebc2004c from
https://github.com/mozilla/l10nregistry-rs.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1757407 - Point to in-tree version of l10nregistry-rs; r=#platform-i18n-reviewers!

Depends on D139850

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1757407 - Comment out criterion in l10nregistry-rs Cargo.toml; r=#platform-i18n-reviewers!

This moves tokio to dev-dependencies to make it clear it is only used for
testing. It also comments out criterion to avoid vendoring it into
mozilla-central. It brings in duplicated crates and large test files.

Depends on D139851

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1757407 - Remove unused dependency from mod.rs; r=#platform-i18n-reviewers!

Depends on D139852

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1757407 - Allow a third duplicated instance of tokio; r=#build!

Unfortunately, the dependencies of l10nregistry-rs require tokio 1.0. This
allows this third duplicated instance. I think it makes more sense to try to
move the other uses in tree to a more modern version than to try to downgrade
the version of tokio required by l10nregistry-rs and dependencies.

Depends on D139853

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1757407 - Re-run mach vendor rust; r=#platform-i18n-reviewers!

Depends on D139854

Comment 7

[Dan Minor [:dminor]]

I opened a pull request to point to m-c here: https://github.com/mozilla/l10nregistry-rs/pull/22

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1757407 - Exclude l10registry-rs from license lint; r=#platform-i18n-reviewers!

This is code written by Mozilla employees but licensed under dual Apache2 / MIT
license and originally hosted on GitHub. Rather than try to create a text that
will pass the license lint, just exclude it from linting.

Depends on D139854

Comment 9

[Dan Minor [:dminor]]

Attachment: Bug 1757407 - Add l10nregistry to RUST_TESTS; r=#platform-i18n-reviewers!

Depends on D139855

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc2744795e74
Exclude l10registry-rs from license lint; r=platform-i18n-reviewers,gregtatum,sylvestre
https://hg.mozilla.org/integration/autoland/rev/5d0c56d4836f
Add l10nregistry-rs to mozilla-central; r=platform-i18n-reviewers,gregtatum,jfkthame,flod
https://hg.mozilla.org/integration/autoland/rev/c4fb7d16f70d
Point to in-tree version of l10nregistry-rs; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/e082a4fab3bb
Comment out criterion in l10nregistry-rs Cargo.toml; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/60a0adaef217
Allow a third duplicated instance of tokio; r=firefox-build-system-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/de4c5921e901
Re-run mach vendor rust; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/7d025f17c479
Add l10nregistry to RUST_TESTS; r=platform-i18n-reviewers,gregtatum

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fc2744795e74
https://hg.mozilla.org/mozilla-central/rev/5d0c56d4836f
https://hg.mozilla.org/mozilla-central/rev/c4fb7d16f70d
https://hg.mozilla.org/mozilla-central/rev/e082a4fab3bb
https://hg.mozilla.org/mozilla-central/rev/60a0adaef217
https://hg.mozilla.org/mozilla-central/rev/de4c5921e901
https://hg.mozilla.org/mozilla-central/rev/7d025f17c479