1757415 - ContentEventHandler.cpp(665,22): error: expected unqualified-id "nsGkAtoms::small" bustage

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

I started hitting this bustage in my local builds today, presumably due to changes in unified boundaries moving things around enough to hit it.

In file included from Unified_cpp_dom_events0.cpp:83:
C:/Users/Ryan/repos/mozilla/dom/events/ContentEventHandler.cpp(665,22): error: expected unqualified-id
          nsGkAtoms::small, nsGkAtoms::span, nsGkAtoms::strike,
                     ^
C:/PROGRA~2/WI3CF2~1/10/include/10.0.22000.0/shared/rpcndr.h(190,15): note: expanded from macro 'small'
#define small char
              ^
dom/file/uri
1 error generated.

We've worked around this bustage previously by undeffing small as needed and that appears to work here as well.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1757415 - Undef small in ContentEventHandler.cpp to avoid conflicting with the definition in rpcndr.h from the Windows SDK. r=smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92b8d062ecba
Undef small in ContentEventHandler.cpp to avoid conflicting with the definition in rpcndr.h from the Windows SDK. r=smaug

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, sounds like that nsGkAtoms::small should be renamed to nsGkAtoms::_small or something rather than adding #undef in each user...

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/92b8d062ecba

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Possibly. If this issue happens just once, undef should be fine.