Closed Bug 1757569 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33016 - Fix/rewrite flaky CSP child-src-cross-origin-load

Categories

(Core :: DOM: Security, task, P4)

Product:
Core
Component:
DOM: Security
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog])

Sync web-platform-tests PR 33016 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33016
Details from upstream follow.

Arthur Sonzogni <arthursonzogni@chromium.org> wrote:

Fix/rewrite flaky CSP child-src-cross-origin-load

The test is flaky. My suspicion: we are waiting for 2 iframes to load.
This is checked from: logTest.sub.js, which relies on a timeout of only
two seconds. I am suspecting this is not enough. This patch switches
away from timeout. Instead, we are waiting for every events
indefinitely.

Also, this was an "automatically" translated test, which makes it hard
to follow. This patch completely rewrite it for my own pleasure.

Bug:1276627
Change-Id: I4842ee5cd6e44e5683611d07e18b31d81097e32c
Reviewed-on: https://chromium-review.googlesource.com/3497841
WPT-Export-Revision: 39a2abf2be8ab9271d955761c38446d0b51ea916

PR 33016 applied with additional changes from upstream: 10e5a38dee7de5e945740df5fd267b6c4d05c429
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

PASS : 3
TIMEOUT: 1
ERROR : 1

Chrome

OK : 1
PASS : 4

Safari

OK : 1
PASS : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/content-security-policy/child-src/child-src-cross-origin-load.sub.html: ERROR
Navigation in iframe not allowed by child-src: TIMEOUT

New Tests That Don't Pass

/content-security-policy/child-src/child-src-cross-origin-load.sub.html: ERROR (Chrome: OK, Safari: OK)
Navigation in iframe not allowed by child-src: TIMEOUT (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2291cd3b8a0b
[wpt PR 33016] - Fix/rewrite flaky CSP child-src-cross-origin-load, a=testonly
https://hg.mozilla.org/integration/autoland/rev/29b8c6f3a974
[wpt PR 33016] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2291cd3b8a0b
https://hg.mozilla.org/mozilla-central/rev/29b8c6f3a974

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.