Closed Bug 1757606 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33020 - [tables] Stop using floats within DistributeTableBlockSizeToSections

Categories

(Core :: Layout: Tables, task, P4)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33020 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33020
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[tables] Stop using floats within DistributeTableBlockSizeToSections

As above. With float logic it was relatively easy to produce sections
that had negative sizes, triggering DCHECKs.

This patch removes the float logic, and instead using fixed-precision.

Bug: 1301165
Change-Id: I426745fbb716a0adce28a8a8798dd90560c2d46b

Reviewed-on: https://chromium-review.googlesource.com/3493514
WPT-Export-Revision: 1bae2325e7a01578605a54d8716a7bc9b5b5515a

Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f1c483a4451
[wpt PR 33020] - [tables] Stop using floats within DistributeTableBlockSizeToSections, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.