Closed Bug 1757639 Opened 7 months ago Closed 7 months ago

Remove operating-system/platform-related preprocessing conditionals from various browser/ CSS files

Categories

(Firefox :: Theme, task, P3)

Desktop
All
task
Points:
1

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox99 --- wontfix
firefox100 --- fixed

People

(Reporter: Gijs, Assigned: sclements)

References

Details

(Whiteboard: [fidefe-2022-mr1-css-linting])

Attachments

(1 file)

Specifically, these files:

browser/base/content/browser.css
browser/themes/shared/browser.inc.css
browser/themes/shared/customizableui/panelUI.inc.css
browser/themes/shared/notification-icons.inc.css
browser/themes/shared/places/places-tooltip.inc.css
browser/themes/shared/sidebar.inc.css
browser/themes/shared/toolbarbutton-icons.inc.css

All have ifdefs in for macOS/Windows/Linux (or gtk)/Android. They can all be replaced with the relevant -moz-platform ifdefs. browser.css has some other ifdefs (for MENUBAR_CAN_AUTOHIDE) that can be left for this bug, they are covered by bug 1752833.

It may be necessary to remove the * mark in front of the relevant files in jar.mn if these files are now @import'd instead of included

Severity: -- → N/A
Type: defect → task
Priority: -- → P3
Points: --- → 3
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Attachment #9266864 - Attachment description: WIP: Bug 1757639 - Remove preprocessor from remaining browser/theme/shared files → Bug 1757639 - Remove preprocessor from remaining browser/theme/shared files r=Gijs
Points: 3 → 1
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26fd063a944b
Remove preprocessor from remaining browser/theme/shared files r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Component: General → Theme
You need to log in before you can comment on or make changes to this bug.