Closed Bug 1757673 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33027 - [FlexNG] Don't truncate margins for flex items

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33027 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33027
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Don't truncate margins for flex items

We had resolved to not truncate margins in the case of algorithms
that handle alignment: https://github.com/w3c/csswg-drafts/issues/6812.

This CL implements this by subtracting out the consumed block size
from the offset rather than setting it to zero when an item breaks
before.

This should also address handling alignment globally for flex items,
but tests for alignment will follow in a separate CL to make the
review simpler.

multi-line-row-flex-fragmentation-016.html is now passing as a result.

Note: There seems to be a bug with how negative margins are handled.
This will be investigated in a follow-up CL.

Bug: 660611
Change-Id: Idf72b721a0dd186d110869c876f709dd600c1a8b
Reviewed-on: https://chromium-review.googlesource.com/3499085
WPT-Export-Revision: 3519dcc4737a45a088163786122c0a0bec2b7e21

Component: web-platform-tests → Layout
Product: Testing → Core
PR 33027 applied with additional changes from upstream: 114cb3e3a979d97721b6cafc65af5e777a5af8a5, 8fa6e1db9bcdd4f8a65055eceab4c6b9f132b1a2

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests

Status Summary

Firefox

PASS: 2
FAIL: 10

Chrome

PASS: 4
FAIL: 8

Safari

PASS: 2
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/flexbox/single-line-column-flex-fragmentation-033.html: FAIL

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-row-flex-fragmentation-016.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-029.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-031.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-044.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-045.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/single-line-column-flex-fragmentation-033.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/single-line-column-flex-fragmentation-034.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/single-line-column-flex-fragmentation-035.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/single-line-row-flex-fragmentation-023.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-break/flexbox/single-line-row-flex-fragmentation-024.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5fc028d5319a [wpt PR 33027] - [FlexNG] Don't truncate margins for flex items, a=testonly https://hg.mozilla.org/integration/autoland/rev/77d309c431e2 [wpt PR 33027] - Update wpt metadata, a=testonly
Regressions: 1760565

https://hg.mozilla.org/mozilla-central/rev/5fc028d5319a
https://hg.mozilla.org/mozilla-central/rev/77d309c431e2

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.