1757756 - Permafailing wasi js/src/util/GetPidProvider.h:14:11: note: macro 'getpid' defined here when Gecko 99 merges to Beta on 2022-03-08

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:

• Central-as-beta
• How to run these simulations
• Failure log

[task 2022-03-02T12:20:08.036Z] In file included from /builds/worker/workspace/obj-spider/dist/system_wrappers/unistd.h:3:
[task 2022-03-02T12:20:08.036Z] /builds/worker/fetches/sysroot-wasm32-wasi/include/unistd.h:156:14: error: too many arguments provided to function-like macro invocation
[task 2022-03-02T12:20:08.036Z] pid_t getpid(void);
[task 2022-03-02T12:20:08.037Z]              ^
[task 2022-03-02T12:20:08.037Z] /builds/worker/checkouts/gecko/js/src/util/GetPidProvider.h:14:11: note: macro 'getpid' defined here
[task 2022-03-02T12:20:08.038Z] #  define getpid() 1
[task 2022-03-02T12:20:08.038Z]           ^
[task 2022-03-02T12:20:08.038Z] 1 error generated.
[task 2022-03-02T12:20:08.038Z] gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:659: Unified_cpp_js_src12.o] Error 1
[task 2022-03-02T12:20:08.038Z] gmake[4]: Leaving directory '/builds/worker/workspace/obj-spider/js/src'
[task 2022-03-02T12:20:08.038Z] gmake[4]: *** Waiting for unfinished jobs....

Could be a fallout of Bug 1757273?
Ryan, do you have a few minutes to check?

Comment 1

[Ryan Hunt [:rhunt]]

It looks wasi related, it seems unlikely to be a regression from bug 1757273. Jan, do you have any idea what this might be from?

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1757756 - Use emulated getpid for WASI to fix the beta-simulation build. r?glandium!

zlib includes unistd.h and the definition of getpid there conflicted with the macro
in GetPidProvider.h, breaking the WASI build on beta.

Comment 3

[Norisz Fay [:noriszfay]]

The patch seems to be working as of today's central as beta simulation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/399e883cdcd2
Use emulated getpid for WASI to fix the beta-simulation build. r=glandium

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/399e883cdcd2

Comment 6

[Cosmin Sabou [:CosminS]]

Fix verified in today's beta-sim.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please submit an uplift request.

Comment 8

[Jan de Mooij [:jandem]]

Comment on attachment 9266257 [details]
Bug 1757756 - Use emulated getpid for WASI to fix the beta-simulation build. r?glandium!

Beta/Release Uplift Approval Request

• User impact if declined: Broken WASI build on beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Doesn't affect Firefox.
• String changes made/needed: N/A

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9266257 [details]
Bug 1757756 - Use emulated getpid for WASI to fix the beta-simulation build. r?glandium!

Approved for 99.0b3. Thanks.

Comment 10

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c53386c664e5

Comment 11

[Intermittent Failures Robot]

1 failures in 2837 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• linux64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1757756&startday=2022-03-07&endday=2022-03-13&tree=all