[wpt-sync] Sync PR 33029 - Add "true" to truthy values list for windowFeatures
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 33029 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33029
Details from upstream follow.
Mason Freed <masonf@chromium.org> wrote:
Add "true" to truthy values list for windowFeatures
Prior to this CL, window.open(url, '', 'noopener=true') would treat
'noopener=true' as if noopener is false. This is currently per-spec [1]
but there is a desire [2][3] to change that.[1] https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-parse-boolean
[2] https://github.com/whatwg/html/pull/7425
[3] https://github.com/whatwg/html/issues/7399Fixed: 1277613
Change-Id: I5b3a7e985a9bb392c2150846b50369cfcd9b05fa
Reviewed-on: https://chromium-review.googlesource.com/3495659
WPT-Export-Revision: 83214e2a1b0618c1dbbeebd81177dde9340fb313
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
NOTE: https://searchfox.org/mozilla-central/rev/ad7ecfa618ec3a65db8405d9f1125059fe4a6a15/testing/web-platform/meta/html/browsers/the-window-object/window-open-noopener.html.ini#7-8
this expected failure should also be applied to noopener=true
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=None
|
|
Assignee | |
Comment 3•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ee77dc08328133f6688d2c6534b4742508b1d86
|
|
Assignee | |
Comment 4•2 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 9 tests and 93 subtests
Status Summary
Firefox
OK : 9
PASS : 161
FAIL : 13
Chrome
OK : 9
PASS : 168
FAIL : 6
Safari
OK : 5
PASS : 15
FAIL : 63
TIMEOUT: 4
NOTRUN : 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL
noopener=1 means the same as noopener: FAIL
noopener separated only by spaces should work: FAIL
Trailing noopener should work: FAIL
Leading noopener should work: FAIL
Interior noopener should work: FAIL
noreferrer should also suppress opener when reusing existing target: FAIL
New Tests That Don't Pass
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?single-1
"popup=true" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?combination
"popup=true,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL (Chrome: PASS, Safari: PASS)
noopener=1 means the same as noopener: FAIL (Chrome: PASS, Safari: PASS)
noopener=true means the same as noopener: FAIL (Chrome: FAIL, Safari: FAIL)
noopener separated only by spaces should work: FAIL (Chrome: PASS, Safari: PASS)
Trailing noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Leading noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Interior noopener should work: FAIL (Chrome: PASS, Safari: PASS)
noreferrer should also suppress opener when reusing existing target: FAIL (Chrome: PASS, Safari: PASS)
/html/browsers/the-window-object/window-open-windowfeatures-values.html
Test noreferrer=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test noopener=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test popup=true, expected interpretation is true: FAIL (Chrome: FAIL)
|
|
Assignee | |
Comment 5•2 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 9 tests and 93 subtests
Status Summary
Firefox
OK : 9
PASS : 161
FAIL : 13
Chrome
OK : 9
PASS : 168
FAIL : 6
Safari
OK : 5
PASS : 15
FAIL : 63
TIMEOUT: 4
NOTRUN : 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL
noopener=1 means the same as noopener: FAIL
noopener separated only by spaces should work: FAIL
Trailing noopener should work: FAIL
Leading noopener should work: FAIL
Interior noopener should work: FAIL
noreferrer should also suppress opener when reusing existing target: FAIL
New Tests That Don't Pass
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?single-1
"popup=true" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?combination
"popup=true,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL (Chrome: PASS, Safari: PASS)
noopener=1 means the same as noopener: FAIL (Chrome: PASS, Safari: PASS)
noopener=true means the same as noopener: FAIL (Chrome: FAIL, Safari: FAIL)
noopener separated only by spaces should work: FAIL (Chrome: PASS, Safari: PASS)
Trailing noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Leading noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Interior noopener should work: FAIL (Chrome: PASS, Safari: PASS)
noreferrer should also suppress opener when reusing existing target: FAIL (Chrome: PASS, Safari: PASS)
/html/browsers/the-window-object/window-open-windowfeatures-values.html
Test noreferrer=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test noopener=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test popup=true, expected interpretation is true: FAIL (Chrome: FAIL)
|
|
Assignee | |
Comment 6•2 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 9 tests and 93 subtests
Status Summary
Firefox
OK : 9
PASS : 161
FAIL : 13
Chrome
OK : 9
PASS : 168
FAIL : 6
Safari
OK : 5
PASS : 15
FAIL : 63
TIMEOUT: 4
NOTRUN : 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL
noopener=1 means the same as noopener: FAIL
noopener separated only by spaces should work: FAIL
Trailing noopener should work: FAIL
Leading noopener should work: FAIL
Interior noopener should work: FAIL
noreferrer should also suppress opener when reusing existing target: FAIL
New Tests That Don't Pass
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?single-1
"popup=true" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?combination
"popup=true,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL (Chrome: PASS, Safari: PASS)
noopener=1 means the same as noopener: FAIL (Chrome: PASS, Safari: PASS)
noopener=true means the same as noopener: FAIL (Chrome: FAIL, Safari: FAIL)
noopener separated only by spaces should work: FAIL (Chrome: PASS, Safari: PASS)
Trailing noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Leading noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Interior noopener should work: FAIL (Chrome: PASS, Safari: PASS)
noreferrer should also suppress opener when reusing existing target: FAIL (Chrome: PASS, Safari: PASS)
/html/browsers/the-window-object/window-open-windowfeatures-values.html
Test noreferrer=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test noopener=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test popup=true, expected interpretation is true: FAIL (Chrome: FAIL)
|
|
Assignee | |
Comment 7•2 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 9 tests and 93 subtests
Status Summary
Firefox
OK : 9
PASS : 161
FAIL : 13
Chrome
OK : 9
PASS : 168
FAIL : 6
Safari
OK : 5
PASS : 15
FAIL : 63
TIMEOUT: 4
NOTRUN : 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL
noopener=1 means the same as noopener: FAIL
noopener separated only by spaces should work: FAIL
Trailing noopener should work: FAIL
Leading noopener should work: FAIL
Interior noopener should work: FAIL
noreferrer should also suppress opener when reusing existing target: FAIL
New Tests That Don't Pass
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?single-1
"popup=true" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?combination
"popup=true,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL (Chrome: PASS, Safari: PASS)
noopener=1 means the same as noopener: FAIL (Chrome: PASS, Safari: PASS)
noopener=true means the same as noopener: FAIL (Chrome: FAIL, Safari: FAIL)
noopener separated only by spaces should work: FAIL (Chrome: PASS, Safari: PASS)
Trailing noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Leading noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Interior noopener should work: FAIL (Chrome: PASS, Safari: PASS)
noreferrer should also suppress opener when reusing existing target: FAIL (Chrome: PASS, Safari: PASS)
/html/browsers/the-window-object/window-open-windowfeatures-values.html
Test noreferrer=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test noopener=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test popup=true, expected interpretation is true: FAIL (Chrome: FAIL)
|
|
Assignee | |
Comment 8•2 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 9 tests and 93 subtests
Status Summary
Firefox
OK : 9
PASS : 161
FAIL : 13
Chrome
OK : 9
PASS : 168
FAIL : 6
Safari
OK : 5
PASS : 15
FAIL : 63
TIMEOUT: 4
NOTRUN : 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL
noopener=1 means the same as noopener: FAIL
noopener separated only by spaces should work: FAIL
Trailing noopener should work: FAIL
Leading noopener should work: FAIL
Interior noopener should work: FAIL
noreferrer should also suppress opener when reusing existing target: FAIL
New Tests That Don't Pass
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?single-1
"popup=true" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?combination
"popup=true,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL (Chrome: PASS, Safari: PASS)
noopener=1 means the same as noopener: FAIL (Chrome: PASS, Safari: PASS)
noopener=true means the same as noopener: FAIL (Chrome: FAIL, Safari: FAIL)
noopener separated only by spaces should work: FAIL (Chrome: PASS, Safari: PASS)
Trailing noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Leading noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Interior noopener should work: FAIL (Chrome: PASS, Safari: PASS)
noreferrer should also suppress opener when reusing existing target: FAIL (Chrome: PASS, Safari: PASS)
/html/browsers/the-window-object/window-open-windowfeatures-values.html
Test noreferrer=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test noopener=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test popup=true, expected interpretation is true: FAIL (Chrome: FAIL)
|
|
Assignee | |
Comment 9•2 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 9 tests and 93 subtests
Status Summary
Firefox
OK : 9
PASS : 161
FAIL : 13
Chrome
OK : 9
PASS : 168
FAIL : 6
Safari
OK : 5
PASS : 15
FAIL : 63
TIMEOUT: 4
NOTRUN : 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL
noopener=1 means the same as noopener: FAIL
noopener separated only by spaces should work: FAIL
Trailing noopener should work: FAIL
Leading noopener should work: FAIL
Interior noopener should work: FAIL
noreferrer should also suppress opener when reusing existing target: FAIL
New Tests That Don't Pass
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?single-1
"popup=true" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?combination
"popup=true,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL (Chrome: PASS, Safari: PASS)
noopener=1 means the same as noopener: FAIL (Chrome: PASS, Safari: PASS)
noopener=true means the same as noopener: FAIL (Chrome: FAIL, Safari: FAIL)
noopener separated only by spaces should work: FAIL (Chrome: PASS, Safari: PASS)
Trailing noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Leading noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Interior noopener should work: FAIL (Chrome: PASS, Safari: PASS)
noreferrer should also suppress opener when reusing existing target: FAIL (Chrome: PASS, Safari: PASS)
/html/browsers/the-window-object/window-open-windowfeatures-values.html
Test noreferrer=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test noopener=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test popup=true, expected interpretation is true: FAIL (Chrome: FAIL)
|
||
Comment 10•2 years ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a3874bdea5c [wpt PR 33029] - Add "true" to truthy values list for windowFeatures, a=testonly https://hg.mozilla.org/integration/autoland/rev/b756ac323fdf [wpt PR 33029] - Update wpt metadata, a=testonly
|
|
Assignee | |
Comment 11•2 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 9 tests and 93 subtests
Status Summary
Firefox
OK : 9
PASS : 161
FAIL : 13
Chrome
OK : 9
PASS : 168
FAIL : 6
Safari
OK : 5
PASS : 15
FAIL : 63
TIMEOUT: 4
NOTRUN : 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL
noopener=1 means the same as noopener: FAIL
noopener separated only by spaces should work: FAIL
Trailing noopener should work: FAIL
Leading noopener should work: FAIL
Interior noopener should work: FAIL
noreferrer should also suppress opener when reusing existing target: FAIL
New Tests That Don't Pass
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?single-1
"popup=true" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html?combination
"popup=true,location,toolbar,menubar,resizable,scrollbars,status" should set BarProp visibility to false: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/the-window-object/window-open-noopener.html?indexed
window.open() with 'noopener' should reuse existing target: FAIL (Chrome: PASS, Safari: PASS)
noopener=1 means the same as noopener: FAIL (Chrome: PASS, Safari: PASS)
noopener=true means the same as noopener: FAIL (Chrome: FAIL, Safari: FAIL)
noopener separated only by spaces should work: FAIL (Chrome: PASS, Safari: PASS)
Trailing noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Leading noopener should work: FAIL (Chrome: PASS, Safari: PASS)
Interior noopener should work: FAIL (Chrome: PASS, Safari: PASS)
noreferrer should also suppress opener when reusing existing target: FAIL (Chrome: PASS, Safari: PASS)
/html/browsers/the-window-object/window-open-windowfeatures-values.html
Test noreferrer=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test noopener=true, expected interpretation is true: FAIL (Chrome: FAIL)
Test popup=true, expected interpretation is true: FAIL (Chrome: FAIL)
|
|
Assignee | |
Comment 12•2 years ago
|
||
Test result changes from PR not available.
|
||
Comment 13•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0a3874bdea5c
https://hg.mozilla.org/mozilla-central/rev/b756ac323fdf
Description
•