1757778 - Nimbus schemas reject in-flight recipes

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, defect, P2)

Description

[Barret Rennie [:barret] (they/them)]

We still ship some recipes with a feature key for backwards compatibility, but the schema updates in bug 1726190 do not allow this key to exist, leading to all recipes being marked as invalid. We have to update the schemas to ignore this additional property when it is present.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1726190

Comment 2

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1757778 - Expose Nimbus schemas as resource:// URIs r?andreio

Comment 3

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1757778 - Accept recipes and enrollments with a feature key r?emcminn

When schemas were updated to support multi-feature, they were not made
backwards compatible with single-feature experiments. Since we ship recipes
that are backwards compatible (i.e., containing both "feature" and "features"
keys, we would end up rejecting all experiments.

Depends on D138929

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1726190

Comment 5

[Barret Rennie [:barret] (they/them)]

The schema is also rejecting feature{s[]}.enabled vs feature{s[]}.value.enabled

Comment 6

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1757778 - Import NimbusExperiment schema from @mozilla/nimbus-shared r?emcminn

Depends on D138929

Comment 7

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1757778 - Update NimbusEnrollment schema based off updated NimbusExperiment schema r?emcminn

Depends on D140759

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/150da87f13dc
Expose Nimbus schemas as resource:// URIs r=andreio
https://hg.mozilla.org/integration/autoland/rev/4462dae86143
Import NimbusExperiment schema from @mozilla/nimbus-shared r=emcminn
https://hg.mozilla.org/integration/autoland/rev/4596f3c5162b
Update NimbusEnrollment schema based off updated NimbusExperiment schema r=emcminn

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d79b5664083
Expose Nimbus schemas as resource:// URIs r=andreio
https://hg.mozilla.org/integration/autoland/rev/817eb3698571
Import NimbusExperiment schema from @mozilla/nimbus-shared r=emcminn
https://hg.mozilla.org/integration/autoland/rev/9d895dc49d93
Update NimbusEnrollment schema based off updated NimbusExperiment schema r=emcminn

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0d79b5664083
https://hg.mozilla.org/mozilla-central/rev/817eb3698571
https://hg.mozilla.org/mozilla-central/rev/9d895dc49d93