1757816 - Inspector EditingSession:getPropertyIndex ignores rule argument and always uses the first rule

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Julian Descottes [:jdescottes]]

The following method:

  getPropertyIndex: function(name, rule = this._rules[0]) {
    const elementStyleRule = this._rules[0];
    if (!elementStyleRule.declarations.length) {
      return -1;
    }

    return elementStyleRule.declarations.findIndex(p => p.name === name);
  },

is obviously wrong and ignores its rule argument

https://searchfox.org/mozilla-central/rev/48c71577cbb4ce5a218cf4385aff1ff244dc4432/devtools/client/inspector/boxmodel/utils/editing-session.js#89

elementStyleRule should be dropped and we should use rule instead. Hopefully this doesn't break any assumption.

Comment 1

[Julian Descottes [:jdescottes]]

Hi Sai!

This is a small issue I spotted while reviewing your patch for Bug 1717176. Would you be interested in trying to fix this?

Comment 2

[Sai Hemanth]

Thanks Julian, I can take this up. I'll send a patch in a short while.

Comment 3

[Sai Hemanth]

Attachment: Bug 1757816 - Use rule parameter in inspector EditingSession:getPropertyIndex. r=jdescottes

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/902ab4b1756d
Use rule parameter in inspector EditingSession:getPropertyIndex. r=jdescottes

Comment 5

[Julian Descottes [:jdescottes]]

Thanks for picking this up quickly :)

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/902ab4b1756d