Closed Bug 1757817 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 33034 - Fix usage of onload = t.step_timeout in WPT tests

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox100 fixed)

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33034 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33034
Details from upstream follow.

Scott Haseley <shaseley@chromium.org> wrote:

Fix usage of onload = t.step_timeout in WPT tests

t.step_timeout directly invokes setTimeout, so this pattern doesn't
actually wait for onload. The pattern, as used elsewhere, should be
something like:

onload = () => t.step_timeout

One app-history test in particular was causing issues as it became
dependent timer task ordering.

Bug: 1220223
Change-Id: I2a8c74e485833a3bc15cc53320c791ecb80452af
Reviewed-on: https://chromium-review.googlesource.com/3499359
WPT-Export-Revision: 887cd5b25d9a6df81d0467bad672438b9bc73c75

PR 33034 applied with additional changes from upstream: 3638c168c6db3f12a8d72f1e70e2d66ced788528

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 1 subtests

Status Summary

Firefox

OK : 7
FAIL: 7

Chrome

OK : 7
PASS: 1
FAIL: 6

Safari

OK : 7
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/app-history/currentchange-event/currentchange-app-history-back-forward-same-doc.html
AppHistoryCurrentChangeEvent fires for appHistory.back() and appHistory.forward(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/currentchange-event/currentchange-app-history-navigate-replace-same-doc.html
AppHistoryCurrentChangeEvent fires for appHistory.navigate() with replace: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/currentchange-event/currentchange-app-history-navigate-same-doc.html
AppHistoryCurrentChangeEvent fires for appHistory.navigate(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/currentchange-event/currentchange-history-back-same-doc.html
AppHistoryCurrentChangeEvent fires for history.back(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-history-back-after-fragment.html
history.back() fires the navigate event and sets hashChange when reversing a fragment navigation: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-history-back-after-pushState.html
history.back() fires the navigate event when reversing a pushState(): FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/forms/the-selectmenu-element/selectmenu-form-state-restore.tentative.html
Test restoring state after form submission: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e95314a89791 [wpt PR 33034] - Fix usage of onload = t.step_timeout in WPT tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e95314a89791

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.