1757925 - Assertion failure: [GFX1 36]: Invalid adjusted target in Canvas2D 0x557e9a1f9520, truefalse, at /gfx/2d/Logging.h:754

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev 96a077ed86f8 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build 96a077ed86f8 --debug --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Assertion failure: [GFX1 36]: Invalid adjusted target in Canvas2D 0x557e9a1f9520, truefalse, at /gfx/2d/Logging.h:754

    ==1118419==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f85f459ba7f bp 0x7ffc7ed95740 sp 0x7ffc7ed95730 T1118419)
    ==1118419==The signal is caused by a WRITE memory access.
    ==1118419==Hint: address points to the zero page.
        #0 0x7f85f459ba7f in mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::WriteLog(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /gfx/2d/Logging.h:755:9
        #1 0x7f85f459b98e in mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::Flush() /gfx/2d/Logging.h:277:7
        #2 0x7f85f45d49ee in mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::~Log() /gfx/2d/Logging.h:270:12
        #3 0x7f85f65c3de7 in mozilla::dom::CanvasRenderingContext2D::DrawImage(mozilla::dom::HTMLImageElementOrSVGImageElementOrHTMLCanvasElementOrHTMLVideoElementOrOffscreenCanvasOrImageBitmap const&, double, double, double, double, double, double, double, double, unsigned char, mozilla::ErrorResult&) /dom/canvas/CanvasRenderingContext2D.cpp:4769:7
        #4 0x7f85f5a65e02 in mozilla::dom::CanvasRenderingContext2D_Binding::drawImage(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/CanvasRenderingContext2DBinding.cpp:2778:28
        #5 0x7f85f64dbb18 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /dom/bindings/BindingUtils.cpp:3306:13
        #6 0x7f85fa46f41f in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) /js/src/vm/Interpreter.cpp:425:13
        #7 0x7f85fa46eb1d in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:512:12
        #8 0x7f85fa4705fe in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /js/src/vm/Interpreter.cpp:572:10
        #9 0x7f85fa465eb6 in CallFromStack /js/src/vm/Interpreter.cpp:576:10
        #10 0x7f85fa465eb6 in Interpret(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:3309:16
        #11 0x7f85fa45cdb3 in js::RunScript(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:394:13
        #12 0x7f85fa46ea18 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:544:13
        #13 0x7f85fa4705fe in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /js/src/vm/Interpreter.cpp:572:10
        #14 0x7f85fa470801 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:589:8
        #15 0x7f85fa5a2f01 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #16 0x7f85f61fac67 in mozilla::dom::EventListener::HandleEvent(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/EventListenerBinding.cpp:62:8
        #17 0x7f85f6a41966 in void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/EventListenerBinding.h:65:12
        #18 0x7f85f6a416ea in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) /dom/events/EventListenerManager.cpp:1310:43
        #19 0x7f85f6a423e9 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) /dom/events/EventListenerManager.cpp:1507:17
        #20 0x7f85f6a373f4 in HandleEvent /dom/events/EventListenerManager.h:395:5
        #21 0x7f85f6a373f4 in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:348:17
        #22 0x7f85f6a36917 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:550:16
        #23 0x7f85f6a39178 in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /dom/events/EventDispatcher.cpp:1085:11
        #24 0x7f85f8594093 in nsDocumentViewer::LoadComplete(nsresult) /layout/base/nsDocumentViewer.cpp:1084:7
        #25 0x7f85f9bdb284 in nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, nsresult) /docshell/base/nsDocShell.cpp:6416:20
        #26 0x7f85f9bdad73 in nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /docshell/base/nsDocShell.cpp:5805:7
        #27 0x7f85f9bdbc0f in non-virtual thunk to nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /docshell/base/nsDocShell.cpp
        #28 0x7f85f4458d2c in nsDocLoader::DoFireOnStateChange(nsIWebProgress*, nsIRequest*, int&, nsresult) /uriloader/base/nsDocLoader.cpp:1377:3
        #29 0x7f85f445815a in nsDocLoader::doStopDocumentLoad(nsIRequest*, nsresult) /uriloader/base/nsDocLoader.cpp:975:14
        #30 0x7f85f44564e0 in nsDocLoader::DocLoaderIsEmpty(bool, mozilla::Maybe<nsresult> const&) /uriloader/base/nsDocLoader.cpp:794:9
        #31 0x7f85f445769d in nsDocLoader::OnStopRequest(nsIRequest*, nsresult) /uriloader/base/nsDocLoader.cpp:677:5
        #32 0x7f85f9bfcebd in nsDocShell::OnStopRequest(nsIRequest*, nsresult) /docshell/base/nsDocShell.cpp:13792:23
        #33 0x7f85f37a0c7a in mozilla::net::nsLoadGroup::NotifyRemovalObservers(nsIRequest*, nsresult) /netwerk/base/nsLoadGroup.cpp:614:22
        #34 0x7f85f37a2263 in mozilla::net::nsLoadGroup::RemoveRequest(nsIRequest*, nsISupports*, nsresult) /netwerk/base/nsLoadGroup.cpp:518:10
        #35 0x7f85f4f1370e in mozilla::dom::Document::DoUnblockOnload() /dom/base/Document.cpp:11540:18
        #36 0x7f85f4ede1cf in mozilla::dom::Document::UnblockOnload(bool) /dom/base/Document.cpp:11478:9
        #37 0x7f85f4efa1db in mozilla::dom::Document::DispatchContentLoadedEvents() /dom/base/Document.cpp:8018:3
        #38 0x7f85f4fad3db in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1147:12
        #39 0x7f85f4fad3db in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1153:12
        #40 0x7f85f4fad3db in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1200:13
        #41 0x7f85f35a31d2 in mozilla::SchedulerGroup::Runnable::Run() /xpcom/threads/SchedulerGroup.cpp:140:20
        #42 0x7f85f35d42de in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:467:16
        #43 0x7f85f35ad2c6 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:770:26
        #44 0x7f85f35abf88 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:606:15
        #45 0x7f85f35ac203 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:390:36
        #46 0x7f85f35d7786 in operator() /xpcom/threads/TaskController.cpp:124:37
        #47 0x7f85f35d7786 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
        #48 0x7f85f35c2253 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1173:16
        #49 0x7f85f35c976a in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:467:10
        #50 0x7f85f416bc06 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:85:21
        #51 0x7f85f408b697 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #52 0x7f85f408b5a2 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #53 0x7f85f408b5a2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #54 0x7f85f81e8c08 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:137:27
        #55 0x7f85fa2f04b3 in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:870:20
        #56 0x7f85f416cafa in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:235:9
        #57 0x7f85f408b697 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:331:10
        #58 0x7f85f408b5a2 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #59 0x7f85f408b5a2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #60 0x7f85fa2efae9 in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:729:34
        #61 0x557e987132f7 in content_process_main /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #62 0x557e987132f7 in main /browser/app/nsBrowserApp.cpp:327:18
        #63 0x7f860988d0b2 in __libc_start_main /build/glibc-sMfBJT/glibc-2.31/csu/../csu/libc-start.c:308:16
        #64 0x557e986eea7c in _start (/home/jkratzer/builds/mc-debug/firefox-bin+0x15a7c)
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /gfx/2d/Logging.h:755:9 in mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::WriteLog(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
    ==1118419==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Mayank Bansal]

https://crash-stats.mozilla.org/report/index/da0d0d1d-b79b-49ab-a8f6-c6a4f0220303#tab-bugzilla

Comment 3

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220303094735-96a077ed86f8.
The bug appears to have been introduced in the following build range:

Start: e329e95ebee5a7f08d39ac905e3f55ecf6ec2bdd (20220301183717)
End: bf53c704f431aad350e8de8850539e0b35f588a1 (20220301193507)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e329e95ebee5a7f08d39ac905e3f55ecf6ec2bdd&tochange=bf53c704f431aad350e8de8850539e0b35f588a1

Comment 4

[Brad Werth [:bradwerth]]

Lee, this is happening due to a Canvas bounds check failure. Would you please see if the changes in Bug 1752456 are responsible?

Comment 5

[Lee Salzman [:lsalzman]]

Attachment: Bug 1757925 - Only warn for AdjustedTarget failure in canvas. r?aosmond

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25788be8b56e
Only warn for AdjustedTarget failure in canvas. r=bradwerth

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/25788be8b56e

Comment 8

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as fixed on rev mozilla-central 20220304041828-3dac5cfdfc06.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

:lsalzman, since this bug contains a bisection range, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Can we land the test too?

Comment 11

[Lee Salzman [:lsalzman]]

Attachment: Bug 1757925 - Add crashtest. r?aosmond

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc04da5eb235
Add crashtest. r=gfx-reviewers,gw

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dc04da5eb235